Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As long as I'm using ImageCache I always wanted to give some presets more descriptive names (namespace is limited and not really good to describe the preset).
Heres a patch that adds the possibility to enter descriptive names for presets. These names are used in listings (e.g. Views or CCK field output selection).
I've added some screenshots to show the new behaviour.
Comment | File | Size | Author |
---|---|---|---|
#3 | imagecache_preset-names-4.patch | 7.31 KB | stBorchert |
#2 | imagecache_preset-names-3.patch | 7.36 KB | stBorchert |
preset_names-03.png | 16.3 KB | stBorchert | |
preset_names-02.png | 42.43 KB | stBorchert | |
preset_names-01.png | 37.59 KB | stBorchert |
Comments
Comment #1
stBorchertBtw.: committing this patch would require nearly all modules depending on ImageCache to rewrite some parts of their code.
Maybe ist better to not change the name of column "presetname" to "presetnamespace" but name the new column "presetrealname" (or something like this).
That would still give users the possibility to enter descriptive names but doesn't force other modules to change their code.
On the other hand the columns are now (with this patch) named according to their contents.
Comment #2
stBorchertOther approach, same result (without renaming column "presetname" to "presetnamespace" and forcing other modules to rewrite their code).
Comment #3
stBorchertOne minor comment change.
Comment #4
smk-ka CreditAttribution: smk-ka commentedI like this. It would also reduce the likelihood to rename presets and having to update all CCK field displays and Views, as described in #596620: Renaming ImageCache preset invalidates formatter display of CCK fields. .
Comment #5
sandrewj CreditAttribution: sandrewj commented#737644: Administrative description of a preset
Comment #6
stBorchert@sandrewj: sorry for re-opening, but this patch has been much older and is on a way to make it in core, too (see #606598: Human readable image-style names).
If you may like to join forces, please update this one here and do not open (or feed) another issue.
Comment #7
sandrewj CreditAttribution: sandrewj commentedI don't mind leaving this one open. The patch I submitted on the other issue is pretty similar and solves the same issues.
Does this issue need to stay open because it is referenced in the D8 core issue?
Would the hope be for the patch to be accepted into the D8 core and then backported to D7 core and to this D6 module or can development continue on this issue independently?
Comment #8
sandrewj CreditAttribution: sandrewj commentedFor now I am marking this as needs work. When the #606598: Human readable image-style names gets finalized/committed for D8 core it can be ported to this module.
Comment #9
fizk CreditAttribution: fizk commentedMarking as ImageCache 3.x Todo.
Comment #10
klonos...actually, the proper status is postponed, but I feel #606598: Human readable image-style names is reeeally close to commit! :D
Comment #11
andypostNow commited #606598-128: Human readable image-style names
Comment #12
klonos...back to active then. Right?