The Search 404 module sometimes returns a 200 response. It would be nice if boost would not cache a page if the page_callback is seach404_page, even if a 200 is given. Also would allow for one to turn off boost for all views without having to specify all paths; I'm sure there are other examples where this would be useful.

CommentFileSizeAuthor
#5 boost-585152.1.patch751 bytesmikeytown2
#4 boost-585152.patch2.6 KBmikeytown2
#2 boost-585152.patch2.6 KBmikeytown2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

Move _boost_get_menu_router() call from boost_db_prep() to _boost_ob_handler(), pass $router_item, or make it a global.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Active » Needs review
FileSize
boost-585152.patch2.6 KB

router item global, moved check into the init() hook. Eventually put a check in like the cacheability box/block thing; check goes into boost_is_cacheable().

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Needs review » Active

committed; would like to see an textarea input, allowing one to disable caching of by content type and/or path (see blocks code).

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Title: Exclude certain page callbacks from being cached » Exclude search404 page callback from being cached
Status: Active » Needs review
FileSize
boost-585152.patch2.6 KB

Guess this can be done in the cacheability textarea with the php filter.

Fix spelling error

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
FileSize
boost-585152.1.patch751 bytes

helps to upload the right file.

dbeall’s picture

dbeall CreditAttribution: dbeall commented
Status: Needs review » Reviewed & tested by the community

works like a champ. had to go get the module and stick it in. trying to get a cached copy.. no luck.
another cool feature.

used browser history no luck, back button, no luck... good to go

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Reviewed & tested by the community » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

shortspoken’s picture

shortspoken CreditAttribution: shortspoken commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Closed (fixed) » Active

Sorry to reopen this, but I encountered the same problem in Drupal 7. Hasn't this been ported/taken over to Drupal 7 version?

Boost: 7.x-1.0-beta3+15-dev
Search 404: 7.x-1.3

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

I believe that the fast 404 module is recommended for this issue now.