Enabling Node displays make the settings and node displays supported by cck_fieldgroup_tabs dissapear

I am not sure which module's responsibility is to integrate with the other

CommentFileSizeAuthor
#6 582618_nd_fieldgroup.patch748 byteshefox
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GiorgosK’s picture

here is the link to the project
http://drupal.org/project/cck_fieldgroup_tabs

swentel’s picture

Project: Node displays » Node displays contributions
Version: 6.x-1.0-beta2 » 6.x-1.x-dev
Component: Code » Other modules support

This belongs in the contrib section from now on.

agrivas’s picture

I think the issue is even deeper. I can see how this is compatible with fieldgroups in general. I am used to creating fieldgroups by dragging a field under a group at the "Manage Fields" tab. Since drag n' drop functionality is disabled with node displays I can't see how can I assign a field to a group.

butler360’s picture

Same issue here. With a content type that already had a group and fields under it, it shows up that way on "Manage Fields" page. If I add a new field, though, I can't see any way to add it to a group.

hefox’s picture

Title: Incompatible with cck_fieldgroup_tabs » Incompatible with fieldgroups

Why is it changing my manage fields display? Manage fields, in my mind, is for the form and a display module should likely not be doing too much too them, unless it's adding more functionality; but atm, as far as I can tell, its getting rid of functionality without any settings to prevent that (for now I commented out the register alter). I need my field groups for my vertical tabs! :(.

display not working when having fieldgroups anyway

in ds_build_fields_and_regions

     $object->content[$key]['#weight'] = $weight;

However since its invoked in alter, fieldgroups has already reordered $node->content so the field is under 'group_whatever' 'groups' now.

However, there's no checking of that, so it adds an entry

which conflicts in content_field $op == 'preprocess_node'

    case 'preprocess_node':
      // Add $FIELD_NAME_rendered variables.
      $addition = array();

      // The location of the field's rendered output depends on whether the
      // field is in a fieldgroup or not.
      $wrapper = NULL;
      if (isset($node->content[$field['field_name']])) {
        $wrapper = $node->content[$field['field_name']];
      }
      elseif (module_exists('fieldgroup') && ($group_name = fieldgroup_get_group($node->type, $field['field_name'])) && isset($node->content[$group_name]['group'][$field['field_name']])) {
        $wrapper = $node->content[$group_name]['group'][$field['field_name']];
      }
    ... 


the isset node content field returns TRUE (though it only contains a weight), so the correct information (ie what's under group name group field) isn't used, so the rendered value is not set correctly.

Just doing a check

if ($object->content[$key]) $object->content[$key]['#weight'] = $weight;

works other than weight for display is ignored.

hefox’s picture

FileSize
748 bytes

Here's a 'temporary' patch till one that works apprioently with fieldgroups. It removes fieldgroups from the node before display.

swentel’s picture

Ok, christmas holidays, time to work on the modules again, sorry a bit for the delays. As a first step, I commited the part where we altered the theme registry for the fields overview form. This works again, I'll review the fieldgroups issue and patch later on!

mautumn’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev

Having similar problem with fieldgroups. They disappeared off a form when I installed NDs, and re-appeared when I removed it... Fieldgroups is too important a feature for me to be without it so I'll have to wait until this "bug" (?) is fixed before I can use NDs.

Looks like a great module though. I hope you can sort this out. Keep up the great work.

Flying Drupalist’s picture

Subscribe

ManyNancy’s picture

Title: Incompatible with fieldgroups » Incompatible with fieldgroups and multigroups
Priority: Normal » Critical

Please support multi-groups as well!

svendecabooter’s picture

Any progress on this? This is blocking me from using this module as well.
If there's anything I can do to help speed up the process, let me know.

pauljb’s picture

subscribe

ManyNancy’s picture

I tried to print one manually in a code field but was not having much luck.

http://drupal.org/node/680104

Can anyone help with this? It should at least be a decent temporary solution.

ManyNancy’s picture

I can't figure out how to do this. Can we have some information on when this might be fixed or any tips on how to implement the fields manually.

Thanks.

Trunkhorn’s picture

Interested in this as well.

ManyNancy’s picture

Hi, I saw this under D7 in the roadmap. Is this feature not coming before D7?

swentel’s picture

No, this is intented for the 6.x-1.1 release, we're working heavily on it.

Flying Drupalist’s picture

So this is definitely coming out after 7.x?

Can I offer $50 to contribute to an earlier release?

christianpound’s picture

subscribe

seutje’s picture

damn, this looked easy to fix at first, but deep is the rabbit hole :(

Andrew Gorokhovets’s picture

Any progress on this?

swentel’s picture

Sorry for the delay - we're a bit stuck too on this feature since it's not *that* easy to implement. We're also constantly shifting on 2 thoughts, namely

  1. Should we only concentrate on support for fieldgroups (and multigroups) for CCK
  2. Or should we introduce our own fielddgroup which listens to fieldgroups coming from modules

Anyone is welcome to add patches of course!

@Flying Drupalist As soon this is in (and 3 other, rather easier issues), there is a new release, D7 has no priority for now. My goal for a new release is to get this out by the end of March.

Flying Drupalist’s picture

Thank you, makes me happy to hear that.

1. I think everyone's looking forward to this.
2. Highly intriguing, I can see this being useful to combine CCK fields + blocks into tabsets. But unless I'm misunderstanding this is not something that can replace CCK fieldgroups, and especially not multigroups. It would be a fun additional. Everyone really really needs #1, so unless there's some way to use the ds fieldgroups to substitute for regular fieldgroups, please implement #1 posthaste.

Our thanks.

aimevp’s picture

subscribe

ManyNancy’s picture

#1 please!

swentel’s picture

Quick update - the dev version of ds and nd_contrib (with nd_cck in it) have working code. It's in fact our own version of fieldgroups (which means that you now can create fieldgroups with DS too, you'll see a new tab called fieldgroups at admin/ds/nd) but the fieldgroups of cck are recognized too! The main problem right now is in the display field overview form with the javascript which isn't listening very well right now - we're solving that issue this week, but we're very very close :)

Note: don't use in production of course!

ManyNancy’s picture

Very cool, thanks!

ManyNancy’s picture

I tried to test it. Latest dev (march 5 contrib / march 9 of ds) of the contrib + ds.

Is this working for multigroups? I see the group, I tried to put it into a region.

The group becomes indented in the admin, probably the js issue you mentioned?

But the group doesn't show up on the node.

Thanks.

okeedoak’s picture

subscribing

ManyNancy’s picture

Are there any updates here?

Thanks.

swentel’s picture

Title: Incompatible with fieldgroups and multigroups » Incompatible with fieldgroups

You can test, works perfectly now! Make sure, you have all latest dev release of the entire Display Suite module. Release 1.1 is coming.

Did a split of though for multigroups, which goes into 1.2, see #753842: Support CCK multigroups

swentel’s picture

Status: Active » Fixed

Marking this one as fixed - release 1.1 pretty soon.

picardo’s picture

subscribing

picardo’s picture

@swentel

I still see this issue on custom content types. I downloaded the dev releases of the entire display suite. The fieldgroups are still missing unfortunately. :-(

swentel’s picture

Can't reproduce though on my local dev machine. I created a content type 'test' and added a fieldgroup which showed up nicely. I think there's something else more fundamental going wrong on your setup (cf your other issue which also has troubles with content types).

chansion.vc’s picture

subscribing

swentel’s picture

Status: Fixed » Closed (fixed)

Marking as closed - fieldgroups is working fine (in dev). Open new issues for other requests regarding fieldgroups.