php 5 errors [#57554]

I note there are frequent PHP5 errors, which are usually resolved by inserting

(array)

somewhere, often in foreach() statement. This case:

Invalid argument supplied for foreach() in C:\workspace\mysite\modules\cck\content.module on line 624
In this case

foreach ($array as $key1 => $value1) {

is fixed if you change it to

foreach ((array)$array as $key1 => $value1) {

I used to get a fair number of these, and I found that if I develop in PHP5 environment I have fewer issues w/ PHP version-related bugs popping up. That's just me.
Thanks

Comment	File	Size	Author
#5	cck_php5_changes.patch	2.54 KB	dado

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dado CreditAttribution: dado commented 6 April 2006 at 10:18

Here's some more

Warning: Invalid argument supplied for foreach() in C:\workspace\mysite\modules\cck\nodereference.module on line 89
Warning: Invalid argument supplied for foreach() in C:\workspace\mysite\modules\cck\content.module on line 625

in each case, add
(array)
to fix.

Comment #2

dado CreditAttribution: dado commented 6 April 2006 at 10:19

and another

Warning: array_pop() [function.array-pop]: The argument should be an array in C:\workspace\mysite\modules\cck\nodereference.module on line 175

Comment #3

dado CreditAttribution: dado commented 6 April 2006 at 10:23

Priority:

Minor

» Normal

The latter one I had to change this

$node_field['nid'] = array_pop($node_field['nids']);

to this

if (is_array($node_field['nid'])) $node_field['nid'] = array_pop($node_field['nids']);

Comment #4

dado CreditAttribution: dado commented 6 April 2006 at 10:25

Oops disregard last post. Maybe change to something like this

if (is_array($node_field['nids'])) {
            $node_field['nid'] = array_pop($node_field['nids']);
          } else {
            $node_field['nid'] = $node_field['nids'];
          }