Here is a first fix,

I found some t() processed format_plural() but this should be fixed first!

CommentFileSizeAuthor
#10 privatemsg_thread_change_delete_4_ported.patch2.59 KBberdir
#5 privatemsg_thread_change_delete.patch1.6 KBandypost
#4 privatemsg_thread_change_delete.patch1.6 KBandypost
#3 privatemsg_thread_change_delete.patch1.6 KBandypost
#2 privatemsg_thread_change_delete.patch935 bytesandypost
#1 privatemsg_thread_change_delete.patch935 bytesandypost
privatemsg_thread_change_delete.patch1.31 KBandypost

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new privatemsg_thread_change_delete.patch935 bytes

Clean patch

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new privatemsg_thread_change_delete.patch935 bytes

Finally :)

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new privatemsg_thread_change_delete.patch1.6 KB

And another one.

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new privatemsg_thread_change_delete.patch1.6 KB

Oh sorry this one is last

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new privatemsg_thread_change_delete.patch1.6 KB

Oh sorry this one is last

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Patch still applies (with 125 lines offset :) ) and works.

litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Fixed
litwol’s picture

litwol commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Fixed » Patch (to be ported)
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Patch (to be ported) » Reviewed & tested by the community

This is a re-roll, no changes to the existing patch.

However, I fixed two bugs that are only in the D7 version:
- wrapped the onSubmit JS code in a function ($) {} wrapper, as this is required for D7
- moved the execute action form below the message listing, not sure why it appears above in D7..

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new privatemsg_thread_change_delete_4_ported.patch2.59 KB

and now with patch...

litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.