Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I got this error message:
Notice: Undefined variable: install_locale in install_import_locales_remaining() (line 1403 of /home/dm7/install.php).
Looked at the code and proposed this fix. I hate seeing php notices.
| Comment | File | Size | Author |
|---|---|---|---|
| install.php_.notice.patch | 775 bytes | mgifford | |
Comments
Comment #1
David_Rothstein CreditAttribution: David_Rothstein commentedYup, makes sense!
Is it really only a PHP notice that this causes? From looking at the code, I would think that it would actually prevent the batch import from working correctly at all...
Note that when rewriting the installer in #524728: Refactor install.php to allow Drupal to be installed from the command line I am reasonably sure that no one ever tested it with language imports... So if you find yourself using this feature, definitely be on the lookout for other problems :)
Comment #2
mgiffordWell, that would explain why
#513940: Installation task progress is not determinable non-visually
wasn't importing the french text for the installation in my tests.
Thank goodness for PHP notices!
Wonder how long this has been broken for?
Comment #3
David_Rothstein CreditAttribution: David_Rothstein commentedSince July 28, apparently - the date that the initial patch at #524728: Refactor install.php to allow Drupal to be installed from the command line was committed :)
So it sounds like this is a critical bug?
Comment #4
mgiffordI'd agree with that!
Comment #5
dddave CreditAttribution: dddave commentedSetting back, ok?
Comment #6
mgiffordYup. That's fine with me. It must have been overlooked in the creation of the new function:
http://api.drupal.org/api/function/install_import_locales_remaining/7
Comment #7
webchickCommitted to HEAD. Thanks!