In the configuration page admin/og/og, there is incorrect gender grammar. For example "Group creator chooses whether her group appears on the registration form. Defaults to on form." should read "Group creator chooses whether his or her group appears on the registration form. Defaults to on form."

Using grammar like this is often an attempt at addressing sexist aspects of the English language, and if this was intentional I applaud you for integrating such attempts into the software, but it is grammatically incorrect. Another problem that becomes obvious even when the correct grammar is used is that of assuming a gender binary world. There is not a grammatically correct way in English to write inclusively of gender identities that fall outside of male and female.

#5 issue568780-take2.patch11.6 KBmarcp
#3 issue568780.patch10.39 KBmarcp
Members fund testing for the Drupal project. Drupal Association Learn more


kiamlaluno’s picture

Category: feature » task

The normal way to avoid writing her or his in English is to use the plural. In the specific, the sentence should be written as group creators choose whether their group appears on the registration form, which is also correct because the group creators are probably more than one.

I am not sure the grammar gender used in the sentence is incorrect; the sentence simply take an assumption about the gender of the group creator. Grammatically speaking, the sentence is correct, as there are not two separate words for creator (one for male creators, and one for female creators).

moshe weitzman’s picture

Status: Active » Closed (works as designed)
marcp’s picture

Title: Incorrect gender grammar in admin/og/og » Grammar and typos at admin/og/og
Status: Closed (works as designed) » Needs review
10.39 KB

The attached patch fixes a typo and addresses evoltech's issue with admin/og/og at the same time. While creating the patch, my editor fixed a few "whitespace at the end of line" issues as well.

The typo that og_views.module served up to admin/og/og was the word "themeing" which is now "theming" in the patch.

The gender issue is addressed by changing "her" to "the new" which makes sense in the context of og/admin/admin which deals with new group creation settings. And, finally, there were a couple places where the help text used the term "post" instead of "group" -- either one makes sense in Drupal-speak, but using group in place of post clarifies things for novice users.

marcp’s picture

Version: 6.x-1.3 » 6.x-2.x-dev

Changed the version - the patch is for 6.x-2.x-dev.

marcp’s picture

11.6 KB

Please use this patch instead -- two instances of "whether her group homepage" were changed to "whether the new group homepage" in og_access.module.

evoltech’s picture

Status: Needs review » Reviewed & tested by the community

Thanks marcp. I tested this out and the new wording addresses the issue quite nicely.

amitaibu’s picture

Status: Reviewed & tested by the community » Fixed

Patch didn't apply, but I changed all "her group" to "the new group".

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.