Spun off from http://drupal.org/node/560750 , if anonymous users have no vertical-tabs permissions (but permission to just add content) then they see an empty vertical tabs box.

Screenshot: http://drupal.org/files/issues/text_format_widget.png

#4 noVerticalTabs.png153.37 KBaspilicious
#2 vertical-tabs.jpg28.96 KBjim0203
#1 vertical-tabs.js-non-existing-fieldsets.patch1.21 KBmhrabovcin
Passed: 14751 passes, 0 fails, 0 exceptions View
Members fund testing for the Drupal project. Drupal Association Learn more


mhrabovcin’s picture

Status: Active » Needs review
1.21 KB
Passed: 14751 passes, 0 fails, 0 exceptions View

Vertical tabs script wasn't checking if there are some fieldset that can be converted to tabs.

jim0203’s picture

28.96 KB

The patch works, but it throws up another problem.

The div with class "vertical-tabs" - i.e., the div that is showing up even though it's empty - has a margin of 10px on top and bottom. When the div is removed, the save and preview buttons are pushed right up into the body-wrapper div - see attached screenshots. I'm not a themer so I wouldn't know where to start with this, but it seems to me that perhaps the logical thing to do would be to add the margin to to the top of the submit/preview buttons and totally remove it from the bottom of the "vertical-tabs" div.

How do I display screenshots inline in a post?

Dave Reid’s picture

Issue tags: +vertical tabs

Adding tag

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
153.37 KB

Patch looks goed.
Nice code comment.
Still Apllies.
It works now with changes that happened overwhile. #2 isn't a problem anymore.

See screenshot for proove!

==> RTBC

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Nice catch. Committed to CVS HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -vertical tabs

Automatically closed -- issue fixed for 2 weeks with no activity.