After selecting an alternative parser (SimplePie module implemented one here; http://drupal.org/node/253619 ) Aggregator does not load it's aggregator.parser.inc. This behaviour makes it impossible to revert to default parser since settings page does not display default parser.
Solution is to load aggregator.admin.inc and others at every page request like other core modules (field) do.
This patch also has some cleanup. Replaces some parts with more readable code. Changes $feed->source_string to $feed->data and $feed->http_headers to $feed->headers.
Comment | File | Size | Author |
---|---|---|---|
#3 | 565718-3-aggregator_api_cleanup.patch | 9.36 KB | mustafau |
#2 | 565718-2-aggregator_api_cleanup.patch | 9.36 KB | mustafau |
aggregator_api_cleanup.patch | 9.21 KB | mustafau | |
Comments
Comment #2
mustafau CreditAttribution: mustafau commentedComment #3
mustafau CreditAttribution: mustafau commentedComment #4
sun.core CreditAttribution: sun.core commentedI think you are effectively removing the pluggable sub-systems from Aggregator here...
Comment #5
retester2010 CreditAttribution: retester2010 commented#3: 565718-3-aggregator_api_cleanup.patch queued for re-testing.
Comment #7
quazardous CreditAttribution: quazardous commentedjust rewrite the _aggregator_get_variables() and put the includes outside does the trick...
Comment #8
Andreas Radloff CreditAttribution: Andreas Radloff commentedSince this is only a problem on the admin pages, wouldn't it be better to instead put it in the top of aggregator.admin.inc and keep aggregator.module as it is:
That would perserve the original intention of (I assume) not including unneccesary files.