Remove database BC layer

I don't think this was tested yet.

Oh, nice patch crossposting :(, haven't seen this one

Your patch seems to be missing a few INSERT-query conversions in system_install() and the strange comment_update_1 function.

I think both patches have the same install problem, the error message is "SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'd7_variable' already exists ". Don't have time to work on it today....

Tagging.

Subscribing! Yum.

Here is a new patch...

Fixed some stuff and changed db_query_range() after a discussion in #drupal. Basically, I made $args optional and moved it behind $from and $count. Either that or adding a array() to all db_query_range() calls without params. Patch is now quit a bit bigger now..

I was able to install locally, so, lets see what happens now...

Did not want to remove the tag...

Forgot one call to queryRange, let's try again...

Some clean-ups...

- All $args are now type hinted and default to an empty array() ("array $args = array()") in both the wrapper and the actual functions.

- Explanation about comment_update_1(): That function is around since D5, contained an non-converted query so I assumed it is ok to just remove it instead of converting and maybe even conflicting with other patches that would remove it in the meantime

- $from and $count are now required params for db_query_range() like queryRange() already was. Previously, they had a default value 0 (probably to help with the func_get_args() magic) but you can't LIMIT 0,0 anyway.

Another cleanup, $options is now type hinted in the db_query* wrapper functions too.

Awesome work folks!!

Perhaps my favourite patch of Drupal 7. :) Committed to HEAD!!

I assume this is covered enough by our DBTNG docs, so marking fixed.

db_add_column() and db_change_column() needs to go away too. Those are very old functions that are useless at least since Drupal 6.

Exactly, not used at all.

Woohoo! Committed to HEAD.