In the latest dev release, the controls option added (Prev/Next) and the pager option (e.g., 1 2 3) should properly degrade for non-js users but does not. It displays broken control links, hides the pager ones, and displays only the first item in the slideshow.

Members fund testing for the Drupal project. Drupal Association Learn more


redndahead’s picture

As far as the pager goes I believe that hiding the pager is degrading correctly. Having a pager doesn't quite make sense as it can't correctly refresh the page. Controls probably should be hidden when js is off. That means starting them hidden and using js to make them show. Will look at that.

mcarbone’s picture

Title: Controls and Pager do not degrade for non-js users » Broken control links display for non-js users

I'm not sure I see the downside to having it work using $_GET parameters, as, for example, Views does for its AJAX pagers on blocks. However, I do agree that it would be better for now to hide than to show broken links. Maybe down the road, if our client requests it, I will submit a patch.

redndahead’s picture

One thing is the pager is implemented completely in js at the moment. We use the cycle plugin's pager. We could use get params which would definitely require some extra coding and we would have to reimplement the pager system ourselves. If you have a patch that would be awesome.

redndahead’s picture

Status: Active » Needs review
3.49 KB

Here is a patch to hide the controls if js is not enabled.

redndahead’s picture

Status: Needs review » Fixed


Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mcarbone’s picture

Title: Broken control links display for non-js users » Support control links and image count for non-js users
Status: Closed (fixed) » Needs review
11.47 KB

Re-opening as I've put together a patch that offers non-js support for previous/next controls and the image counter. It isn't full-featured (the pager is fully handled by cycle, so that's not supported, and the thumbnail hover elements don't work) but it's enough to give a non-js user the ability to page through without missing content.

redndahead’s picture

Status: Needs review » Closed (fixed)

@mcarbone Does this introduce a new way to have to theme the previous and next controls? If so can you please assign it to 3.x. Either way can you open a new issue with this patch.

intyms’s picture

but it's enough to give a non-js user the ability to page through without missing content.

I have patched my views slideshow.
I am using the thumbnail hover mode.
If i disable Javascript i see that Next and Previous links disappeared. Nothing else happened.
Is this the expected behavior?

In my opinion, the disappearing Next/Previous links isn't very good.
Because some users may assign a background image to these links. And without that background, the page will not look as expected for them.
Maybe, it will be good to put a checkbox on "views slideshow configuration" and to ask the user if he wants the links to be hidden or not.
The default value of checkbox has to be "to not hide the links". Then, this feature can be also implemented to the 2.x version of the slideshow (because it will not break the slideshow during the upgrade) .
Am i missing something?

redndahead’s picture

Wouldn't it confuse your users to have previous and next links when clicking on them does absolutely nothing?

intyms’s picture

31.24 KB

#10 redndahead

My webpage shows an alert message to the users with disabled Javascript.
Here's a screenshot. See attached file please.
I plan to add also a link to the "Alert message" with detailed descriprion about "how to enable javascript".

What do you think about adding a similar feature to Views Slideshow (i mean, to display an alert mesage at the top of the slideshow when JS is disabled.)
The easiest way is to use noscript tag.

mcarbone’s picture

I lost track of this issue. In any case, the patch I wrote doesn't affect the theme at all for js users, although it does have to tweak some CSS so things display/hide properly for non-js users. New issue here: