hi,

i created a patch to update the defaults for downloads like on http://piwik.org/docs/javascript-tracking/ and a condition to only add piwikTracker.setDownloadExtensions when it's not the default.

regards

CommentFileSizeAuthor
#9 piwik-545886.patch3.67 KBpebosi
#6 piwik-545886.patch2.63 KBpebosi
#1 piwik-545886.patch1.56 KBpebosi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pebosi’s picture

pebosi CreditAttribution: pebosi commented
Status: Active » Needs review
FileSize
piwik-545886.patch1.56 KB
hass’s picture

hass CreditAttribution: hass commented

This is a good list of extensions. We should also add an update hook.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Needs work

CNW for the update hook.

pebosi’s picture

pebosi CreditAttribution: pebosi commented

Hi,

what kind of update should be perfomed?

regards

hass’s picture

hass CreditAttribution: hass commented

Old extension list to new extension list if current extension list EQ original extension list. Otherwise all users with the old extension list will always get piwikTracker.setDownloadExtensions() added with the old extension list to the footer.

pebosi’s picture

pebosi CreditAttribution: pebosi commented
FileSize
piwik-545886.patch2.63 KB

Updated my patch including an update function. hope it's what you meant.

regards

pebosi’s picture

pebosi CreditAttribution: pebosi commented
Status: Needs work » Needs review
hass’s picture

hass CreditAttribution: hass commented

yep, looks good

pebosi’s picture

pebosi CreditAttribution: pebosi commented
FileSize
piwik-545886.patch3.67 KB

Updated my patch to overwrite drupal's default maxlenght for textfield to 255. 128 was not enough for the new default extensions.

regards

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Fixed

Committed your patch as is, but changed the update hook number to 6003. THX.

hass’s picture

hass CreditAttribution: hass commented

Also ported to google_analytics.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.