Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Poking around the code this module is the most confusing task I've had to undertake with drupal. I have a few specific questions:
Why all the define() statements? Wouldn't it make maintenance simpler to just hardcode the defaults into views_slideshow_views_slideshow_option_definition() (and where ever else)?
Why so many include files? Again, wouldn't it be easier for maintenance for to amalgamate some of these?
Why the hardcoded JS in the views_slideshow.theme.inc? It would seem neater to me to separate that out and use drupal_set_js() to include both the script and the variables, in Drupal.settings.views_slideshow.variablename.
If agree with any of these suggestions, consider this a task. I'd be happy to provide patches if I get around to creating them.
Comments
Comment #1
redndahead CreditAttribution: redndahead commentedMoving to 2.x
If you would like to start some patches I would be interested to see what you have in mind.
Comment #2
fearlsgroove CreditAttribution: fearlsgroove commentedAgreed there's definitely cleanup to be done. 2.x is somewhat better and stuff is moved around. My preference would be not to add new features or do non-bugfix cleanup to 1.x, but there's a relatively sizable user base for this module. Further while all one needs to do is reconfigure the view after upgrading to 2.x, it's still not a clean upgrade path. Thus, I'd say patches that handle cleanup would be quite welcome, I just won't have much time to write them myself :D
Comment #3
redndahead CreditAttribution: redndahead commentedMarking as fixed. Feel free to reopen if you still have problems.
Comment #4
naught101 CreditAttribution: naught101 commentedFine by me.