Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The D7UX mockups call for a top level Content item, which would immediatey lead to the "Find content" screen. The current Drupal 7 code is almost there, but still has an RSS settings item blocking the implementation of this by default and aggregator and book also add subitems.
The D7UX IA document at http://spreadsheets.google.com/pub?key=r3NqKYK4UMfelsw-YQsKxdA&single=tr... says aggregator is targetted as a config & modules option, and book was not mentioned, so I made the following changes:
- Found stale mentions of /admin/content/node (which were wrong before this patch and would be right after this patch, but still finer to use /admin/content)
- Moved /admin/content/content/node to /admin/content (and admin/content/node)
- Moved /admin/content/content/comment to /admin/content/comment
- Moved /admin/content/book to the same path but as a tab (rationale: not on the mockups or IA plan but is a different view on the content implementation so belongs as a tab IMHO)
- Moved /admin/content/aggregator to /admin/settings/aggregator as seen on the IA plan above
This is how it looks with aggregator and book module enabled:
Note that RSS publishing and aggregator are now top leve items on "Site configuration", but that section is about to split into subcategories (see on the IA above and #510110: IA : Configuration & Module).
| Comment | File | Size | Author |
|---|---|---|---|
| #32 | admin-content-comments.patch | 730 bytes | Gábor Hojtsy |
| #21 | aggregator-535564-tests.patch | 33.25 KB | Gábor Hojtsy |
| #17 | aggregator-535564-17.patch | 29.17 KB | pwolanin |
| #16 | aggregator-535564-16.patch | 29.17 KB | pwolanin |
| #15 | aggregator-535564-15.patch | 27.98 KB | pwolanin |
Comments
Comment #1
Gábor HojtsyForgot to tag.
Comment #2
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD.
Comment #3
deekayen CreditAttribution: deekayen commentedLooks like this broke tests in HEAD.
Comment #4
deekayen CreditAttribution: deekayen commentedfixed through #535990: Remove the admin overview test
Comment #5
Gábor HojtsyAdding tag.
Comment #6
pwolanin CreditAttribution: pwolanin commentedthis patch moved 2 pages to the same path 'admin/settings/aggregator'.
Comment #7
pwolanin CreditAttribution: pwolanin commentedthe easiest fix would be to revert this patch totally - I don't understand why feeds would move out of content.
Comment #8
pwolanin CreditAttribution: pwolanin commentedHere's a minimal patch that restores functionality. The fact that tests didn't fail, suggests an obvious hole in test coverage - we shoudl at least exercise every page once.
Comment #9
pwolanin CreditAttribution: pwolanin commentedComment #10
karschsp CreditAttribution: karschsp commentedsubscribe
Comment #11
pwolanin CreditAttribution: pwolanin commentedActually, most of this should have moved to admin/structure NOT admin/settings.
Comment #12
catchLet's at least get this working again.
Comment #13
Bojhan CreditAttribution: Bojhan commentedLets go for structure now, it seems rather silly to put this as the only one in its own category on Configuration & Modules. We should revisit this later on, but I see no real objections atm.
Comment #14
pwolanin CreditAttribution: pwolanin commentedafter discussion with Bojan and catch, this moves the paths to admin/structure
Comment #15
pwolanin CreditAttribution: pwolanin commentedre-roll for conflicts w/ registry ripping patch
Comment #16
pwolanin CreditAttribution: pwolanin commentedper webchick/catch/Bojan: admin/config/services/aggregator
Comment #17
pwolanin CreditAttribution: pwolanin commentedoops - fix path in access callback arguments
Comment #19
yoroy CreditAttribution: yoroy commentedPostponed #535564: D7UX IA: actionable top level content item on this one. It would help if we can name the new category 'Web services' in this patch here. saves us the renaming in the other one.
Comment #20
Gábor Hojtsyyoroy meant #557792: Configuration page: Web services category. I'm on fixing the test errors.
Comment #21
Gábor HojtsyTests were failing due to non-updated numbers in the menu callbacks (due to how the placeholders changed positions). Peter also missed updating paths in the aggregator.api.php file. No other files with missed paths found, so adding updated patch. Aggregator tests pass for me and this establishes the new Web services category which was agreed up on #557792: Configuration page: Web services category, while (as in Peter's motivation), it fixes two paths pointing to different callbacks.
Comment #23
Gábor HojtsyUhm, hum, not even managed to run those tests?
Comment #24
Gábor HojtsyOk, retesting was successful :) Now only needs human review. :)
Comment #25
catchAll looks good and tests are passing now, RTBC.
Comment #26
webchickCommitted to HEAD. Thanks!
Let's make sure we document this change.
Comment #27
moshe weitzman CreditAttribution: moshe weitzman commentedGood grief. Web services have been around for 10 years and have little to do with aggregator and RSS publishing. Thats XML-RPC, SOAP, etc. Could we not overload this term, please.
Comment #28
IncrediblyKenzi CreditAttribution: IncrediblyKenzi commented+1 moshe.. It's been overloaded to death already.
Content aggregation from third party services is COMPLETELY different from web services (which is more aimed at remote invocation / processing than it is gathering data). Feed services seems more appropriate here.
But please, please, please don't confuse the two, especially given the existence of things like the services module and its associated submodules.
Comment #29
webchickThe intent was to put these sorts of modules together, since they're all about getting data into and out of Drupal. Other suggestions?
Comment #30
Pasqualledata services
Comment #31
pwolanin CreditAttribution: pwolanin commented"remote content"?
Comment #32
Gábor HojtsyComment module was not updated with the original patch. This makes a strange item appear in the menu_router table, which has 0 as its access callback, no title and other fun things :)
Comment #33
Dries CreditAttribution: Dries commentedWeb service is overloaded but generic so it fits a lot of modules (e.g. Mollom module, reCaptcha module). Maybe it should be 'Web services and aggregation' or 'Web services and syndication'?
Comment #34
Dries CreditAttribution: Dries commentedCommitted #32, by the way. Thanks Gábor.
Comment #35
stBorchertAs mentioned earlier in #557792: Configuration page: Web services category: why not simply use "Services"?
Comment #36
catchI'd be fine with just Services, I sort of thought that was the proposal (or maybe just got fixated on the URL). Adding syndication/aggregation as a suffix also seems fine.
Comment #38
Bojhan CreditAttribution: Bojhan commentedContinue discussion on categories should continue in #627080: [meta-issue] Additional categories admin/config , this issue has been documented.