CVS edit link for tom78

I am a Designer and Webworker from Germany. I will upload my themes for the drupal community. This is my first theme to upload(demo site): http://www.reizkraft.com

best regards

CommentFileSizeAuthor
#5 bluefun.zip69.01 KBtom78
#4 bluefun.zip68.94 KBtom78
#1 bluefun.zip67.33 KBtom78
#1 blfun.jpg58.41 KBtom78

Comments

tom78’s picture

StatusFileSize
new58.41 KB
new67.33 KB

The zip file and a screenshot. It's a simple theme with 2 lavalamp menus, 1-3 columns and a fixed width.
Demo: http://reizkraft.com

ultimateboy’s picture

Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

The theme is good, minor details only. The javascript included in the template.php should simply be placed in the .info file instead. The javascript in page.tpl should, but doesnt really have to be put into its own .js file and included via .info. Doing it this way will include it in the javascript compression.

I'm not so sure I like this being in the page.tpl. Is there not an alternative using the classes that drupal provides? If not, I'd probably use hook_preprocess_page() to add an additional body class based on those conditions, and then use css to set the properties needed.

<?php if ((arg(2) == 'themes') || (arg(2) == 'track')) { ?>
<style type="text/css">
#outerColumn {border-right: none !important;}
#rightCol {display: none;}
</style>
<?php } ?>

There is also quite a few empty divs in your page.tpl (mainly in the header). Remember that you have the "clear-block" class available, so you dont have to add empty clear divs: <div class="clr"></div>.

Finally, a minor thing is "Powered by Reizkraft.com" in the footer... I dont mind "designed by" or "drupal theme by" but "powered" seems a bit strong.

Really none of these are game stoppers, just small details.

tom78’s picture

thanks... :)
ok. i will change it...

best regards

tom78’s picture

StatusFileSize
new68.94 KB

Now it is ok... :)

best regards

tom78’s picture

StatusFileSize
new69.01 KB

ups. Sorry... this is the file.

ajk’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes
Status: Closed (fixed) » Fixed
Issue tags: +Theme review

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.