Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As seen on http://drupal.org/node/484860#comment-1835260 and follow up comments, if we change the default admin theme for Drupal, the tests will not even run. Because the definite plan is to change the default admin theme, this is not too good. catch suggested I open an issue here and see how we can resolve this, so we can commit enabling the new admin theme by default.
Comments
Comment #1
boombatower CreditAttribution: boombatower commentedJust from initial read, this would seem to be an issue with the tests themselves. One thing to note is that we had discussions about the tests actually "testing" the themes as they somewhat do since you can see they are specific to them...or some part of testing is.
I'll look into this shortly.
Comment #2
boombatower CreditAttribution: boombatower commentedDefinitely an issue with tests themselves.
For example:
Block Functionality: 144 passes, 65 fails, and 17 exceptions
I'm going to guess they do not run on pifr because modules page is modified in some way....checking.
Comment #3
boombatower CreditAttribution: boombatower commentedLooks like that patch features a version of the theme that failed to output page content. Since PIFR (currently) enables SimpleTest via modules page that would explain the issue.
To summarize there are two issues at hand:
1) The patch in that version was flawed (I assume a newer [unflawed] version will run tests)
2) The tests may depend on some parts of theme, although I doubt very extensively.
I will go ahead and run some tests on newer patch from that issue.
Comment #4
boombatower CreditAttribution: boombatower commentedI cannot actually get the theme to work...I just get blank content area. Hmmm..
Comment #5
Gábor Hojtsy@bombatower: #473080: Blocks are not inherited when switching themes You need to enable the content and help blocks via DB until that is fixed.
Comment #6
Gábor HojtsyOr maybe more like #477800: No themes enabled upon install...
Comment #7
boombatower CreditAttribution: boombatower commentedIt would seem this is no longer an issue...as seven is the new default admin theme and test still pass.
Comment #8
Gábor HojtsyYes, I've ended up updating the tests in the issue.
Comment #9
boombatower CreditAttribution: boombatower commentedTo confirm then, this is fixed?
Also could you briefly describe or point me to what needed changing.
Comment #10
Gábor Hojtsy@bombatower: when we tried to enable the theme by default here (http://drupal.org/node/484860#comment-1835260), it said "Failed to run tests"... Later when we tried again at http://drupal.org/node/484860#comment-1874040 we got actual tests failures, so we got a concrete lists of tests designed for Garland. Things like looking for breadcrumbs on the admin pages or looking for the exact wording of the logout link as "Log out" were among the culprits. The first "Failed to run tests" message led us to think it is a systemic problem with how tests are run, but then we got actual test failures, so it was either solved or was a temporary(?) glitch earlier; or just an issue with what was in that patch...