Patch details:

  • fapi conversion.
  • Adds status messages, comments and language fixes.
  • Adds watchdog messages for category and feed additions and deletions.
  • Edit forms: checks for duplicates - title for category, title + url for feeds.

Please review.

Thanks.
-K

CommentFileSizeAuthor
aggregator_1.patch31.74 KBZen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Committed to HEAD. Seems to work perfectly.

Zen’s picture

Zen CreditAttribution: Zen commented
Status: Fixed » Closed (fixed)
tenrapid’s picture

tenrapid CreditAttribution: tenrapid commented
Status: Closed (fixed) » Active

Investigating this issue I found that with this patch the listing of categories and sources under the 'news aggregator' menu item is completely gone.

Was this intended?
If so I will mark this fixed again, if not I could provide a patch to restore the former menu structure.

Zen’s picture

Zen CreditAttribution: Zen commented

I vaguely remember seeing them too.. Can you tell me if you can see them when you revert to 1.274? I can't - I only see sources, but no categories menu or group items. So I'm not sure if this is related to this patch or if it is something else.

Either way, a change like that would have been documented above - so no, not intended.

-K

tenrapid’s picture

tenrapid CreditAttribution: tenrapid commented
Status: Active » Fixed

I'm so sorry, it is not related to this patch. I saw large areas of yellow in ViewCVS but I should have looked closer.

Zen’s picture

Zen CreditAttribution: Zen commented
Status: Fixed » Closed (fixed)

No worries :)

-K