Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When you place a drupal menu block, menu items that the user does not have access to are not displayed. However, when building a menu view with this module, all menu items are shown regardless of user permissions.
Comment | File | Size | Author |
---|---|---|---|
#5 | menu_node_views-expose_menu_links_attributes-527514-5.patch | 1.76 KB | gabriel.achille |
#5 | interdiff.txt | 1.67 KB | gabriel.achille |
#3 | 527514-filter.patch | 2.14 KB | agentrickard |
Comments
Comment #1
agentrickardYup. Care to work a patch?
Comment #2
agentrickardNote: I think we need a hook_views_query_alter() here, to assert that {menu_links}.hidden == 0. Not sure, however.
Comment #3
agentrickardHere is the basis for a full patch. This adds filters for 'hidden', 'external', 'has_children' and 'external' columns. These need better handlers.
For now, set the filter 'Menu: Visibility" to 'is equal to' zero.
Comment #4
agentrickardComment #5
gabriel.achille CreditAttribution: gabriel.achille commentedFollowing integration of the patch Exposed "hidden" field (in both 6.x-1.x and 7.x-1.x branch) we had to reduce the scope of this one: attribute hidden is already exposed.
Plus i changed some wording of description field to stick to the description present in the schema information for the menu_links table (
modules/system/system.install
)This patch should actually work for both 6.x an 7.x
Comment #6
agentrickard@gabriel.achille
This module is seeking a new maintainer. Is your team interested?
Comment #7
gabriel.achille CreditAttribution: gabriel.achille commented@agentrickard
Mmmm yes I've been thinking to that since our last exchange on issue 1361746 on menu_node module. I am assuming we are talking of maintenance for both modules menu_node and menu_node_views. Are we not ? How many time do you usually spend for this 2 modules, or how many time you think you should spend ? ;)
I need to have a quick talk here internally but yes my personal opinion is that this is a reasonable module to start maintenance with and i am keen to do it.
Comment #8
agentrickardDo I spend? Zero.
Should I spend? 2 hrs/week.
Comment #9
gabriel.achille CreditAttribution: gabriel.achille commentedok
are we talking about maintenance for both modules menu_node and menu_node_views ?
Comment #10
agentrickardYes. They are fairly stable. MNV gets more requests these days.
Comment #11
gabriel.achille CreditAttribution: gabriel.achille commented@agentrickard:
Just had a quick talk internally with my team (3 dev including me), and that definitely something we can do.
How shall we proceed ?
Comment #12
agentrickardI'll give you commit access and release management and monitor for a bit. Then we can transfer project ownership after a stable release or two.
Comment #13
joelpittet