Image module sends bad HTTP headers [#524530]

The generate URL, e.g. http://example.com/image/generate/thumbnail/sites/default/files/pictures..., returns the proper image but with a 500 Internal Server Error HTTP status code. This is because the image module does not use the updated header format that was introduced in #147310: Implement better cache headers for reverse proxies.

This patch fixes that. It also adds proper HTTP status codes when the generated image cannot be returned.

Comment	File	Size	Author
#3	image-headers-2.patch	9.88 KB	c960657
#3
	image-headers-1.patch	9.62 KB	c960657

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Dries CreditAttribution: Dries commented 20 July 2009 at 01:16

Status:

Needs review

» Reviewed & tested by the community

Excellent patch -- this looks good to me. My only reservation was that 10 seconds feels long but that is really minor as this code shouldn't trigger that often.

Comment #2

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 20 July 2009 at 13:18

Hm. I think we could probably move this down to more like 2 or 3 seconds at the most. Then it wouldn't appear like an error to someone browsing the site.

The expanded tests look really helpful.

@c960657, was there a particular reason why 10 was chosen?

Comment #3

c960657 CreditAttribution: c960657 commented 20 July 2009 at 17:52

File	Size
image-headers-2.patch	9.88 KB

The 10 seconds was chosen on an assumption that after that long the image generation is (almost) definitely done. But I guess the client can just try several times, if for some reason the generation takes very long. I changed it to 2.

I doubt any browsers actually request the image again after the specified time, but some web spiders may support the header. I just added a note about this, so that people reading the code wont expect too much.