Aside from minor coding style issues, my main motivation for this patch is to fix $context = NULL as a first argument when $conf is not defined with a default value, so since the second arg is not optional, the first cannot either, I think.

CommentFileSizeAuthor
ctools_relationships.patch7.17 KBmarkus_petrux
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markus_petrux’s picture

markus_petrux CreditAttribution: markus_petrux commented
Status: Active » Needs review

This $context = NULL pattern is being replicated in content relationships implemented elsewhere, and I would fix those in CCK as soon as you can confirm the patch here is correct, as I'm in doubt if the args are really mandatory.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Fixed

Yeah, must be a leftover from all the changes that this poor system has been put through. Thanks!

markus_petrux’s picture

markus_petrux CreditAttribution: markus_petrux commented

Sweet.

Also fixed these in CCK node/user relationships. I used this issue for the CHANGELOG entry in CCK branches 6.x-2.x and 6.x-3.x.

For reference:
http://drupal.org/cvs?commit=240196
http://drupal.org/cvs?commit=240198

Thanks! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.