AFAICT image_style_url() and image_style_generate_url() do exactly the same, i.e. they call each other depending on the return value of the file_exists() call. Also, the tests for the two functions, testImageStyleGenerateUrl() and testImageStyleUrl(), are completely identical except for the function name used.
I seems like the two functions had different purposes at some point during the development (see the patch attached to #44 in [#491456] - they were then called image_preset_url() and image_preset_generate_url()), but in their current state one of them is redundant.
This patch kills image_style_generate_url().
Comment | File | Size | Author |
---|---|---|---|
#2 | image_style_generate_url-2.patch | 5.8 KB | c960657 |
image_style_generate_url-1.patch | 5.55 KB | c960657 | |
Comments
Comment #2
c960657 CreditAttribution: c960657 commentedReroll.
Comment #3
Dries CreditAttribution: Dries commentedGood catch. Committed to CVS HEAD. Thanks.
Comment #4
drewish CreditAttribution: drewish commentedhumm... it was definitely by design... i'm not so sure i like this... need to think about it some more.