Took me all day to figure out, but filter_form() is missing some key information on parameters, mostly notably the $parent one, which is required if you want multiple formats on the same page. This patch fixes the documentation of this.

CommentFileSizeAuthor
#5 filter.module_22.patch815 bytesm3avrck
#4 filter.module_21.patch815 bytesm3avrck
#1 filter.module_20.patch770 bytesm3avrck
filter.module_19.patch1.01 KBm3avrck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
FileSize
filter.module_20.patch770 bytes

Ooops, patch had debug code. Here's the real one.

Zen’s picture

Zen CreditAttribution: Zen commented

Nitpick: Missing periods at the end.
I'm also not sure that the caption for $parents is entirely accurate as it might be required even if there's only one parent which is not 'format'.

-K

Zen’s picture

Zen CreditAttribution: Zen commented
Status: Reviewed & tested by the community » Needs work
m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
Status: Needs work » Reviewed & tested by the community
FileSize
filter.module_21.patch815 bytes

Zen, good call, both fixed.

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
FileSize
filter.module_22.patch815 bytes

Zen, good call, both fixed.

Zen’s picture

Zen CreditAttribution: Zen commented

+1 :)

-K

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)