Hi,
I found that the height of the masthead is not correctly set when enabling the theme for the first time. This is because of the default settings in theme-settings.php
:
'mastheadfixedfluid' => '184px',
It should be changed to 184 without 'px' because the 'px' part will be added in page.tpl.php
~line 149
'mastheadfixedfluid' => '184',
And my another concern is the default settings array in theme-settings.php
and template.php
are not the same. Can't tell if it will create any bugs but according to http://drupal.org/node/177868 it says "Make sure $defaults
exactly matches the $defaults
in the template.php
file."
Thanks for creating this nice and very configurable theme :)
Comment | File | Size | Author |
---|---|---|---|
#1 | simply_modern-20091026.patch | 501 bytes | joestewart |
Comments
Comment #1
joestewart CreditAttribution: joestewart commentedAnd a simple patch file to commit
Comment #2
Corey Smith CreditAttribution: Corey Smith commented