While not a critical bug, this is a very important one; formsapi promises a glorious new day of modules being able to alter system forms. However, system forms that do not respect proper flow can't be properly modified.

In something I was attempting to do this weekend, this bit me on forum.module.

I recoded forum.module's forum add/edit/delete paths to respect proper form flow.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

Status: Active » Needs review

This is a patch.

webchick’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
8.17 KB

Tested creating forums, forum containers, posting topics and moving topics, editing, deleting topics. The only thing that didn't work without problems was leaving a shadow copy, but this bug was present in HEAD too without this patch.

Attached patch is the same, just removes the drupal_gotos at the end of the _submit functions and changes them to return statements.

Marking RTBC.

killes@www.drop.org’s picture

I'll commit it tomorrow if I don't hear objections. It is a rather nice code improvement.

killes@www.drop.org’s picture

Status: Reviewed & tested by the community » Fixed

applied, I'd like to see the same improvements for taxonomy_admin() :p

Anonymous’s picture

Status: Fixed » Closed (fixed)