Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
While not a critical bug, this is a very important one; formsapi promises a glorious new day of modules being able to alter system forms. However, system forms that do not respect proper flow can't be properly modified.
In something I was attempting to do this weekend, this bit me on forum.module.
I recoded forum.module's forum add/edit/delete paths to respect proper form flow.
Comment | File | Size | Author |
---|---|---|---|
#2 | forum.module_13.patch | 8.17 KB | webchick |
forum-formsapi.patch | 8.11 KB | merlinofchaos | |
Comments
Comment #1
webchickThis is a patch.
Comment #2
webchickTested creating forums, forum containers, posting topics and moving topics, editing, deleting topics. The only thing that didn't work without problems was leaving a shadow copy, but this bug was present in HEAD too without this patch.
Attached patch is the same, just removes the drupal_gotos at the end of the _submit functions and changes them to return statements.
Marking RTBC.
Comment #3
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedI'll commit it tomorrow if I don't hear objections. It is a rather nice code improvement.
Comment #4
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedapplied, I'd like to see the same improvements for taxonomy_admin() :p
Comment #5
(not verified) CreditAttribution: commented