file_check_directory() should create recursively [#515280]

Staring in 5.0.0 PHP's mkdir() adds an option to create directories recursively. I think we should do this by default so I'd be able to replace:

file_check_directory($d = file_directory_path() .'/foo', FILE_CREATE_DIRECTORY);
file_check_directory($d = file_directory_path() .'/foo/bar', FILE_CREATE_DIRECTORY);
file_check_directory($d = file_directory_path() .'/foo/bar/baz', FILE_CREATE_DIRECTORY);

with

file_check_directory($d = file_directory_path() .'/foo/bar/baz', FILE_CREATE_DIRECTORY);

Comment	File	Size	Author
	file_check_directory_recursive.patch	1.12 KB	drewish

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

drewish CreditAttribution: drewish commented 10 July 2009 at 03:11

Issue tags:

+D7FileAPIWishlist, +trivial

adding some tags

Comment #2

jmstacey CreditAttribution: jmstacey commented 10 July 2009 at 03:19

subscribing for notification on commit.

Comment #3

quicksketch

he/him

CreditAttribution: quicksketch commented 10 July 2009 at 03:24

Status:

Needs review

» Reviewed & tested by the community

This makes perfect sense to me. If you're curious about the drupal_chmod() right below the changed line, it does seem a little redundant but it serves the purpose of notifying watchdog if permissions are denied while chmoding the directory.

It'll be great to remove some loops in FileField with this enhancement. Currently I'm doing something like this:

$full_path = '';
foreach (explode('/', $directory) as $path) {
  $full_path .= $path . '/';
  file_check_directory($full_path, FILE_CREATE_DIRECTORY);
}

In comparison this is a dream. Thanks PHP 5!

This patch makes appropriate changes to our tests and is ready to go.

Comment #4

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 10 July 2009 at 03:47

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs documentation

Committed with the addition of a small comment from drewish in IRC, since i had to go off and look up what parameters mkdir started taking while I wasn't looking. :)

Thanks! Please document this in the upgrade guide so that other modules can get rid of similarly nasty code.