Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We made a design decision early on to dynamically calculate things like price and weight for items in the shopping cart to avoid having stale data in cart items. Through an IRC conversation today it came to my attention that the attributes module doesn't follow this design when it comes to the storage of adjusted SKUs. The SKU is stuffed into $item->data when the item is added to the cart, and any time that item is loaded, $item->model will be updated to $item->data['model']. If the adjusted SKU for that product + options were to change, the change would not be reflected on that product.
Without rewriting our data model at this point, I propose the simplest solution I can imagine... add a nodeapi check when a node is saved to see if there are any uc_cart_products for that nid and update their data arrays accordingly.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 508878_update_cart_models.patch | 3.66 KB | Island Usurper |
| #2 | 508878_update_cart_models.patch | 3.21 KB | Island Usurper |
Comments
Comment #1
rszrama CreditAttribution: rszrama commentedActually, duh, this would have to be on whatever form it is that updates adjusted SKUs or could cause them to be reset, not through hook_nodeapi(). Also, Damien Tournoud pointed out that we could alternately move the logic from uc_attribute_add_to_cart_data() to uc_attribute_cart_item() to calculate the current adjusted SKU. Per his advice, the performance hit of that extra query would be negligible since 1) we only really need to run the query when we know a cart item has attributes and 2) MySQL query cache will take care of repeated queries. This solution would be even less code intensive, and I should've picked up on it the first time. ; )
Comment #2
Island Usurper CreditAttribution: Island Usurper commentedYeah, I think the code makes more sense this way, too.
Comment #3
rszrama CreditAttribution: rszrama commentedComment #4
Island Usurper CreditAttribution: Island Usurper commentedFound a mistake where the adjusted model number wasn't being applied to the cart item correctly. Patch corrects this.
I've also noticed that the technique used here doesn't work for customers who are already at the checkout review step. If they complete checkout, their order will still have the old adjusted SKU. Considering that any old orders will also have the old model number as well, I don't see this that big of a problem. I also don't think customers spend a lot of time on the review page, so it's not like fixing this will solve that many problems.
Comment #5
Island Usurper CreditAttribution: Island Usurper commentedTalked to Ryan about that limitation, and he agreed that it's not a big deal.
Committed.