Attached patch:

  • Removes dead code from book_admin().
  • Converts book_outline to fapi _submit model. Related issue.
  • Replaces drupal_goto with return('url').
  • Adds formatting fixes.

I think that's about it.

Thanks
-K

CommentFileSizeAuthor
#3 book-module_0.patch8.97 KBmerlinofchaos
#1 book-module.patch8.97 KBmerlinofchaos
book.module_14.patch8.47 KBZen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
FileSize
book-module.patch8.97 KB

Rerolled slightly to send $nid through the form path rather than rely on arg(1).

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

I did a reasonable but not thorough test on this; if one other person tests it and thinks it's good, I believe we can RTC this.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
FileSize
book-module_0.patch8.97 KB

Whoops! I didn't cvs update foolishly. Let's try THIS patch.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Tested, committed to HEAD.

Zen’s picture

Zen CreditAttribution: Zen commented
Status: Fixed » Closed (fixed)