If you pass no arguments (or empty arguments) to file_load_multiple() it'll try to load every file in the database. Found this when working on comment_load_multiple() which was a straight cut and paste but had a test exposing the bug.

CommentFileSizeAuthor
#3 file_504422.patch1.46 KBdrewish
file_load_multiple.patch2.28 KBcatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
drewish’s picture

drewish CreditAttribution: drewish commented
FileSize
file_504422.patch1.46 KB

good call. personally though i think it's better to fail early.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

That makes (enough) sense to me. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.