Timer counts not properly incremented [#50181]

You may say its not a critical bug? Well, its more crazy then critical.

The problem is in start_timer function.

Its your function:

function timer_start($name) {
  global $timers;

  list($usec, $sec) = explode(' ', microtime());
  $timers[$name]['start'] = (float)$usec + (float)$sec;
  $timers[$name]['count'] = isset($timers[$name]['count']) ? $timers[$name]['count']++ : 1;
}

Any timer's count field is always 1. Just don't know... Maybe its some php bug or else. Try it, you'll see.
P.S. My PHP 4.3.6.

But this works:

  $timers[$name]['count'] = isset($timers[$name]['count']) ? ++$timers[$name]['count'] : 1;

Probably it'll work for U too.

Crazy, ha?

Comment	File	Size	Author
#3	bootstrap.inc_8.patch	653 bytes	puregin
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

markus_petrux CreditAttribution: markus_petrux commented 19 February 2006 at 19:06

It is initialized to 1 the first time you call, say timer_start('mytimer'). The next time you call it, the counter is incremented.

Comment #2

puregin CreditAttribution: puregin commented 19 February 2006 at 21:11

Priority:

Critical

» Normal

Can't reproduce. For example, the page timer seems to work fine. I'm marking this as normal priority.
I'm running PHP 5.0.4. Djun

Comment #3

puregin CreditAttribution: puregin commented 19 February 2006 at 21:42

File	Size
bootstrap.inc_8.patch	653 bytes

I spoke too soon. This bug does appear to exist. I tried

  $time = timer_read('page');                                                                                                                             
  timer_start('page');                                                                                                                            
  $count = $timers['page']['count'];                                                                                                                     
  echo t(' Page execution time was %time ms, and the page timer was accessed %count times.', array('%time' => $time, '%count' => $count));

This indeed gives the wrong answer (1) for count, rather than the expected count (>= 2) unless the count is preincremented. Does this have to do with operator precedence? In any case, here's a patch...