please, look at http://drupal.org/node/50001

Why this bug is critical? Well, I dont' want my users to reveal the real URL names. That's my point.

CommentFileSizeAuthor
#18 friendly url in destination 48.patch453 bytesdoq
#17 friendly url in destination.patch453 bytesdoq
#4 common.inc.patch_0.txt388 bytesdoq
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

puregin’s picture

puregin CreditAttribution: puregin commented
Title: no friendly URL in ?destrination= » no friendly URL in ?destination=
Category: bug » feature
Priority: Critical » Normal

This needs more details - please include all of the information we need to follow this up in the actual issue, if possible. It's not clear to me, even from the forum topic, what you want to do. Do you want to be able to alias numerical user ids in paths?

I'm filing this as a 'normal'feature request. 'Critical' is reserved for something that break Drupal for everyone.

Thanks, Djun

doq’s picture

doq CreditAttribution: doq commented

Ok. So how to achive this.

1. Make an url alias for e.g. 'admin/comment'. Let it be 'test'.
2. Goto 'test'.
3. Take a look at the real url at 'edit' link. Its http://bla-bla/comment/edit/114?destination=admin%2Fcomment

So, as I see the destination variable is not 'test'. But it must be 'test' as far I think. I want my users to see 'test' there.
Got it?

doq’s picture

doq CreditAttribution: doq commented
Version: 4.7.0-beta4 » 4.7.0-rc3
Assigned: doq » Unassigned
Category: feature » bug

will try to fix this.

doq’s picture

doq CreditAttribution: doq commented
Title: no friendly URL in ?destination= » no friendly URL bug in ?destination=
Status: Active » Needs review
FileSize
common.inc.patch_0.txt388 bytes

Patch done. Tested. Working.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Version: 4.7.0-rc3 » 4.7.0

hmm, do we want this?

doq’s picture

doq CreditAttribution: doq commented

Hmmm. Hope so:)
Using such a patch for a long time and having no problems.

P.S. I sometimes see ?destination= when searching in search engines (weird, how that could get there).
And I see smth like this: articles/artificial-intelligence?destination=taxonomy/term/10 or smth similar.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented

I am ok with committing it, I guess. Waiting a bit for more opinions.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Category: bug » task
moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

looks good to me. is trivial enough to just set to RTBC

doq’s picture

doq CreditAttribution: doq commented
Version: 4.7.0 » 4.7.2
Dries’s picture

Dries CreditAttribution: Dries commented

Doesn't apply against HEAD.

doq’s picture

doq CreditAttribution: doq commented

what do you mean??

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Status: Reviewed & tested by the community » Needs work

The patch cannot be applied for some reason.

doq’s picture

doq CreditAttribution: doq commented
Assigned: Unassigned » doq
Zach Harkey’s picture

Zach Harkey CreditAttribution: Zach Harkey commented

+1 doq, you have a greenlight, just need to tweak the patch, right? Push it over the finish line, dude — there are many of us who need this.

doq’s picture

doq CreditAttribution: doq commented
Version: 4.7.2 » 4.7.3

ok

doq’s picture

doq CreditAttribution: doq commented
Status: Needs work » Needs review
FileSize
friendly url in destination.patch453 bytes

for 4.7 CVS

doq’s picture

doq CreditAttribution: doq commented
FileSize
friendly url in destination 48.patch453 bytes

for CVS

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Version: 4.7.3 » x.y.z
Status: Needs review » Reviewed & tested by the community

applied to 4.7.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Killes- it has not been applied to 4.7 as far as I can tell.

Committed to HEAD.

doq’s picture

doq CreditAttribution: doq commented
Status: Fixed » Reviewed & tested by the community

please apply to 4.7

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

this was committed to 4.7.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)