While doing a code review, i found a orphan for loop that generated multiple of tens for the items per page menu. Using dynamic code for such a purpose is a poor allocation of cpu time, where as the patch uses a static menu array. Reason to use patch: more efficient, better programming convention, easier to maintain (I added a comment).
../ubercart/uc_order/uc_order.admin.inc

CommentFileSizeAuthor
#2 uc_order.admin_.inc_.patch792 bytesthenorman
uc_order.admin_.inc_.patch203 bytesthenorman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thenorman’s picture

thenorman CreditAttribution: thenorman commented
Status: Reviewed & tested by the community » Needs review

Wrong Status.

thenorman’s picture

thenorman CreditAttribution: thenorman commented
FileSize
uc_order.admin_.inc_.patch792 bytes
rszrama’s picture

rszrama CreditAttribution: rszrama commented
Category: bug » task
Status: Needs review » Closed (duplicate)

I noticed this fix came through in a separate patch on a rogue string literal. So, it's fixed. : )