Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There appear to be a few legacies from very old versions of this module. This patch cleans them up:
1) comment_notify_page had a bunch of unnecessary, outdated code. It was changed to comment_notify_disable_page (the _page keeps it from accidentally being called as hook_disable()).
2) the hook_help only contained the module description which is no longer used since D5.
3) hook_mail() wasn't documented as such.
4) The function to create a list of options was abstracted. This was not strictly necessary but makes the code nicer.
5) A comment about needing a <br> and not liking it was fixed using a clear-block div.
The one thing I didn't touch but thought about was to try and do some abstraction on _comment_notify_mailalert() but I'm not convinced I can really create any value there yet, so I'm leaving that for later.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | cleanup-comment-notify.patch | 6.13 KB | merlinofchaos |
| cleanup-comment-notify.patch | 5.87 KB | merlinofchaos | |
Comments
Comment #1
merlinofchaos CreditAttribution: merlinofchaos commentedThis patch is against HEAD. Sorry about that, thought I was at HEAD when I was not.
I went ahead and kept it with my change to the br because the change that's in there is IMO less nice than mine. But you can go either way on that, I think.
Comment #2
gregglesCommitted - thank you! http://drupal.org/cvs?commit=224840
I don't generally backport things to 5.x myself but if someone else wants to I will apply them.
Comment #3
gregglesThis module is no longer actively developed for Drupal 5. If someone wishes to take over as the 5.x maintainer I would consider it, but these days everyone should really upgrade to Drupal 6.x.