Remove redundant code from node_link()

On http://php.net/array_key_exists its explicitly stated that array_key_exists() works on objects, too.

Oops. I missed that comment, thanks

$links = $node->links is because you have to return the value, otherwise you would have to introduce another if statement at the return clause, which is possibly slower than having a temporary variable.

hmm... $links is initialized at the top of node_link(). It does not need to be initialized again. Anything returned by hook_link is appended (or array_merged) to $node->links.

This is node_view():

  if ($links) {
    $node->links = module_invoke_all('link', 'node', $node, !$page);
  }

This is module_invoke_all():

function module_invoke_all() {
  $args = func_get_args();
  $hook = array_shift($args);
  $return = array();
  foreach (module_implements($hook) as $module) {
    $function = $module .'_'. $hook;
    $result = call_user_func_array($function, $args);
    if (isset($result) && is_array($result)) {
      $return = array_merge($return, $result);
    }
    else if (isset($result)) {
      $return[] = $result;
    }
  }

  return $return;
}

Other hook_link implementation I've seen just do:

function example_link($type, $node = 0, $main = 0) {
  $links = array();
  if (whatever) {
    $links[] = l('foo', 'bar');
  }
  return $links;
}

I don't get why node_link is different. Sorry, maybe it is in front of me, but I can't see it. I wouldn't have post about it, but it seems to me that even if the expression where array_key_exists() is used in node_link is TRUE (see below), $node->links is still empty. Hence, this code is not needed. Well, that's what it seems to me.

    if (array_key_exists('links', $node)) {
      $links = $node->links;
    }

Is it possible that $node->links contains something else before that point? Maybe filled at node load time by another module? If so, if that is correct, then it looks like other hook_link implementations should also behave as node_link does?

Thanks for checking :-)

Here's a patch that removes that piece of code from node_link().