Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mcrittenden’s picture

Version: 6.12 » 6.x-dev

This is still a problem. Reproduced in Chrome 5.

mcrittenden’s picture

Issue tags: +Novice
Caligan’s picture

Status: Active » Needs review
FileSize
523 bytes

Verified still a problem in 6.19 on Firefox 3.6 and IE 8. Patch fixes it in both.

Status: Needs review » Needs work

The last submitted patch, drupal-485414-1.patch, failed testing.

daniels220’s picture

Status: Needs work » Needs review
FileSize
316 bytes

Reroll, see if that fixes it.

Never mind, D6 patch... The fix makes some sense, although it's a little odd that LIs would need padding-left? Normally they're list-style-position:outside; meaning that it's the [UO]L that needs the padding.

Anyways, still needs review from someone who can verify the fix. I'm not familiar enough with Drupal to test it.

pillarsdotnet’s picture

FileSize
446 bytes

Another approach. The styles for menu items should not be applied to bullets within the content block.

pillarsdotnet’s picture

Title: Bullets overlap their text in install page » Bullets overlap their text in install page (Styles for menu items should not be applied within the .content block)

Status: Needs review » Needs work

The last submitted patch, garland.list-style.patch, failed testing.

pillarsdotnet’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
913 bytes

Gratuitous re-roll; no code changes; still works.

Gábor Hojtsy’s picture

Version: 6.x-dev » 8.x-dev
Status: Reviewed & tested by the community » Needs review

Bugs are fixed first in the current development version. I assume same bug applies to Garland in all Drupal versions.

pillarsdotnet’s picture

I'm not entirely sure that the bug exists within the d8 version of Garland, which is very different from the d6 version.

Nonetheless, here is a forward-port of the patch:

pillarsdotnet’s picture

jhood’s picture

Version: 8.x-dev » 7.x-dev

Garland was removed from core in #911054: Remove Garland from Core

xjm’s picture

#11: garland_style_css-no_menu_styles_in_content_block-485414-11.patch queued for re-testing.

Let's see if the previous patch applies to 7.x.

xjm’s picture

Issue tags: +Needs manual testing

Patch applies to D7. Now let's confirm that the css bug is reproducible in D7 and is fixed by this. I'd suggest screenshots before and after applying the patch.

Note that the D7 installer will not have this screen and will not be in Garland, so you will need to test with a different nested list. Edit: There might be a specific inheritance that causes it as well.

tom friedhof’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
157.97 KB

This is no longer an issue in D7. This was already fixed in garland for Drupal 7. Nested lists are no longer an issue.

Using the same html that is output in D6 that creates this issue and pasting it in a basic page on a vanilla install of Drupal 7 shows that nested lists are no longer an issue. Attached is the screenshot showing that this is fixed without needing to apply any patch at all.

philosurfer’s picture

#16 +1

bvirtual’s picture

Status: Reviewed & tested by the community » Needs review

#16 +1

pillarsdotnet’s picture

Version: 7.x-dev » 6.x-dev
FileSize
913 bytes

So it appears that this problem only exists in D6. Re-uploading the patch from #9.

philosurfer’s picture

Status: Needs review » Reviewed & tested by the community

#19 not working...

xjm’s picture

Status: Reviewed & tested by the community » Needs review

Um. How is it not working, and if it is not working, then why is it RTBC? :)

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.