New features [#482020]

Hi,
Regarding to: http://drupal.org/node/343936#comment-1663766
I've got some website where I need to make some voucher functionality, so I think this module will be good for start.
I don't know which exactly new functionality will be there, it will be added during the testing, but I'm sure nothing will be broken on existing functionality.
I just made a quick review of this module and I think it's good point to start.

CHANGES:
- Token support instead of t() replacement, it will open gate for other available tokens without hardcoding anything
- invvoucher as CCK field, not as hardcoded field. User should be able to choose where he want to place this field and if it's mandatory or not (it could be some optional discount voucher)
- user can choose how invitation voucher is generated, if it's a number or some token with number
Please let me know what do you think about that.

Comments

Comment #1

dear_anton CreditAttribution: dear_anton commented 4 June 2009 at 21:06

- Token support instead of t() replacement, it will open gate for other available tokens without hardcoding anything

Please, explain why should it?

- invvoucher as CCK field, not as hardcoded field. User should be able to choose where he want to place this field and if it's mandatory or not (it could be some optional discount voucher)

It adds dependence on other module. When I've started with Drupal 5 CCK was not a part of Drupal distro. Also it makes module installation more complete for user and programmer both

- user can choose how invitation voucher is generated, if it's a number or some token with number

Admin could add any string as voucher at version for Drupal 6. I thing nobody else should because order support - for example using of bad words or trademarks - it have be under control or site owner will get in trouble

Comment #2

kenorb CreditAttribution: kenorb commented 4 June 2009 at 22:00

Please, explain why should it?
Using Token you have different tokens like [site-name], or some tokens related to specified content types like dates, custom fields with surnames, names, etc.
People using different modules which provide different tokens, you can't hardcore your own tokens.

- invvoucher as CCK field
CCK is still not part of Drupal distro, it's external module and most people can't even realize to do the website without it
http://drupal.org/project/usage/cck
http://drupal.org/project/usage/drupal
More than 50% using it

- user can choose how invitation voucher is generated
I mean user with specified permission to administer vouchers to change it format and generate it using in example mixing with some tokens:
V-[company-name]-[random-number]