This is a child task for #422380: Convert all core module to use new static caching API focusing on the aggregator module.

Files: 
CommentFileSizeAuthor
#3 jamesan_480102-3.patch1.11 KBJamesAn
Passed: 11881 passes, 0 fails, 0 exceptions View
#2 jamesan_480102-2.patch1.11 KBJamesAn
Passed: 11862 passes, 0 fails, 0 exceptions View
#1 jamesan_480102-2.patch1.15 KBJamesAn
Passed: 11885 passes, 0 fails, 0 exceptions View

Comments

JamesAn’s picture

Status: Active » Needs review
FileSize
1.15 KB
Passed: 11885 passes, 0 fails, 0 exceptions View

The aggregator module has two static vars, neither of which are ever reset. This patch inserts inline comments explicitly stating that these static vars don't use drupal_static() as is done elsewhere.

JamesAn’s picture

FileSize
1.11 KB
Passed: 11862 passes, 0 fails, 0 exceptions View

As mentioned in #480122-2: Update blogapi module to use drupal_static(), most static vars should be converted over to use the drupal_static() method.

JamesAn’s picture

FileSize
1.11 KB
Passed: 11881 passes, 0 fails, 0 exceptions View

Oops. Forgot the ampersand in front of drupal_static().

catch’s picture

Status: Needs review » Reviewed & tested by the community
Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.