In filefield_field_update, the code checks if it's processing a new node, and if it is, it returns early as there can't be any old items to delete. The very same check could be used on new node revisions, as the files won't be deleted either and it saves a few cycles not to node_load the original node.

The performance hit isn't huge in normal operations, but bites quite more when batch processing a lot of nodes :-)

Members fund testing for the Drupal project. Drupal Association Learn more


DeFr’s picture

Status: Needs work » Needs review

I've just checked and the patch seems to still applies cleanly to 3.x-dev (it was made against the 3.0 release), so I guess this needs review :-)

quicksketch’s picture

Makes sense to me. I should be able to put this in next time I'm applying patches.

quicksketch’s picture

Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.