Does not work when an admin theme is set

Hi Paul, thanks for the feedback!

I'm not really sure how to handle the admin theme issues. Because regions are theme specific, there's not really a way to have a configure link for a region from a different theme. For instance, if your default theme is a Zen theme, and your admin theme is Garland, Zen has regions that Garland doesn't have (content-top, content-bottom, closure), and Garland has a region that Zen doesn't have (content). The role that has 'Manage Regions' should be seeing the site with the theme they want to manage the regions for.

As far as your other issues let me clarify that as of now the way this module works is by setting the block visibility to 'Show on only the listed pages'. Any block that has been set to have a visibility setting different than that will display as "Locked." Eventually, I'd like to think of a way to add more custom visibility options, but I'd rather err on the side of simple UI then advanced features.

I'm not sure why you were having that weirdness when adding a nodeblock. Can you try this out for me?

• Navigate to a node page, ie node/1
• Click 'configure' in one of the regions.
• Click an "Add new" link to add a new nodeblock.
• Add the content for the nodeblock and hit submit.
• You should then be redirected back to 'node/1' (or whatever path you clicked configure on) and the nodeblock should be already activated in that region. The nodeblock will only display on node/1. This is by design.

Paul, can you download the latest version from github and test it out to see if you are still having this problem? The UI has changed considerably since your posting of this issue, so I'd like to see if this is still an issue.

Paul,
You know the problem may be with the translation module now that I think about it. I wonder if adding the translation actually changes what the arg() function returns. Is there a way you can test it with the translation module off, to see if that's true?

Thanks,
James

Paul, first of all, thanks so much for spending the time to troubleshoot this. In looking through the nodeblock module, I see no reason why it would make a difference which order you install nodeblock or region_manager.

Can you copy and paste the path that you are at after clicking one of the "Create" links (on your install that isn't working)? ie, node/add/page/garland/left?destination=node/1 or something like that.

Hi there

I'm experiencing the same problems - with no Internationalization / Language

Garland is my Admin Theme & Tapestry the main theme - same Admin-theme bug + "Locked" blocks issue

Ok, well now we at least have more than one user with the issue so I'm setting this to active. I have a pretty strong suspicion this is due to the admin theme, so I'll have to test that out sometime and see where its coming from.

I disabled the Admin Theme, which fixed the Theme displayed, but not the Locked Blocks

Paul, can you try out this patch and see if it fixes the issue? Thanks

Ok, thanks for trying that out so quick!

I think I've tracked down the bug for the admin/build/block page. The menu callback for that page sets the custom_theme, but does so after region_manager has already been called. I feel like this is a bug in block.module, that it sets $custom_theme but doesn't unset $theme (forcing to re-init the theme).

Try this patch.. I'm not crazy about this implementation because it's using preprocess_page to manually add the region_manager menus to the region variable, which feels messy to me, and could potentially break again by another module doing something similar.

Ok, I think I've tracked down all bugs associated with having an admin theme active. Try the attached patch!

After submitting the patch I had to re save region manager settings as the admin bars in the theme regions was non existent.

...this issue was not resolved. The one of manually adding blocks.

That's strange; I didn't run into either of those issues while testing myself. I'll do some re-testing.

Thanks, your coding is really impressive.

/me blushes.
Aww, shucks... Thanks! ;)

Thanks for your help in tracking this down!

So I tested this patch again, and it is working well for me with an admin theme. Paul, can you try again?

I've committed the patch: http://drupal.org/cvs?commit=256442
I figure this way we can be sure we're both working from the same code. Drupal.org should package up a new dev version by tomorrow.

I just ran into this issue with the latest stable release. Good to see you guys already worked on it. When will it be committed to the stable release?

Hi aschiwi, you're right, it's about time for another release. Do you mind testing out the dev release to see if it fixes your issues?

q0rban, thanks for the super quick reply! I really like this module, it's great for clients.

I installed the dev release today. It solves the issue mentioned here and does not seem to bring up new issues. Here's what I tested:

I added new blocks (using nodeblock), configured block titles and moved blocks around. I checked and changed settings at admin/settings/region_manager (my blocks are called widgets), I changed what kinds of blocks are available at admin/settings/region_manager/regions/MYTHEME. Did not run to any kinds of problems.

I also love how you can now set visibility so I can uninstall http://drupal.org/project/region_visibility.

Hi q0rban,

I just ran into this again, forgetting I had already known the cause of it :D
I had the dev running without problems on a site from March until a couple of days ago, when I ran updates.

How about another release soon? :)

Thanks,
Anja