On of my pet peeves has been the fact that hook_file_download() passes a path to a file in rather than a $file object. This forces each module to query the database to load it rather than being passed into the hook.

CommentFileSizeAuthor
hook_file_download_obj.patch.patch4.71 KBdrewish
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Issue tags: +API change

bump - would be nice to have before freeze

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

bump - let's re-roll?

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Version: 7.x-dev » 8.x-dev

At the current stage in the Drupal 7 development cycle this seems to be more a feature than a bug.
Moving to Drupal 8.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Issue summary: View changes
Issue tags: +Media Initiative
slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs work » Closed (duplicate)
Related issues: +#2148353: File access (hook_file_download) does not use an EntityAccessController
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -Media Initiative +D8Media

Fix media tag.