Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As discussed in #422362: convert form.inc to use new static caching API with pwolanin and chx, let's open a separate issue to deal with the $reset parameter in form_options_flatten().
Comment | File | Size | Author |
---|---|---|---|
#11 | 437018-11.patch | 1.22 KB | JamesAn |
#7 | 437018-7.patch | 1.22 KB | JamesAn |
#5 | jamesan_437018-5.patch | 1.22 KB | JamesAn |
#2 | jamesan_437018-2.patch | 1.09 KB | JamesAn |
Comments
Comment #1
JamesAn CreditAttribution: JamesAn commentedThinking about it some more, wouldn't it pretty straight-forward to remove the $reset param using a helper function?
Original code:
Modified code:
We'd need some documentation to make this obvious in plain language.
Comment #2
JamesAn CreditAttribution: JamesAn commentedMy webdev box runs out of memory while running the tests, but everything passes so far. So here it goes.
Comment #3
Dries CreditAttribution: Dries commentedLooks good to me!
Comment #5
JamesAn CreditAttribution: JamesAn commentedRerolled patch against the comment added in #422362: convert form.inc to use new static caching API.
Comment #6
catchmissing period.
Comment #7
JamesAn CreditAttribution: JamesAn commentedThanks for catching that!
Comment #9
lilou CreditAttribution: lilou commentedretest.
Comment #11
JamesAn CreditAttribution: JamesAn commentedRerolled.
Comment #13
cburschkaPending a passing test with the new HEAD, this patch looks good.
Comment #14
cburschka[Duplicate post, sorry.]
Comment #15
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.