URL aliases not removed for some legacy project nodes that were deleted

Holy cow, there are a lot of these:

mysql> SELECT COUNT(*) FROM url_alias u LEFT JOIN project_projects pp ON u.src = CONCAT('node/', pp.nid) WHERE pp.nid IS NULL AND u.dst RLIKE 'project/';
+----------+
| COUNT(*) |
+----------+
|     1028 | 
+----------+
1 row in set (10.45 sec)

I guess we need a DB update to run a DELETE query like that. There might be a better way to write this query. ;) Suggestions for improvement welcome.

Ran this on d6.d.o and had no problems. Also tested that the URL alias is removed when I delete project nodes. Any objections?

path.module does this cleanup itself:

function path_nodeapi(&$node, $op, $arg) {
  ...
      case 'delete':
        $path = 'node/'. $node->nid;
        if (drupal_get_path_alias($path) != $path) {
          path_set_alias($path);
        }
        break;
    }
  ...
}

Tested and this works. We don't need the hunk in project.inc, after all.

I guess it doesn't really hurt to leave the cleanup DB update in project.install and leave this issue in this queue, but this seems most likely legacy goo from d.o badness. The newest deleted project node with a stale URL alias still in the table is node/143062 -- we have no way of knowing what version of path.module was deployed on d.o at that time, but perhaps it was something old and buggy.

See also #431386: URL aliases not cleaned up when projects are deleted