Make Shipping Rate Markup a little more dummy-proof [#427970]

One of my clients recently added a value to the "Shipping Rate Markup" field for USPS shipping (with markup type set to Addition $). But we noticed that when orders were placed, the markup wasn't applied. Turns out they had a dollar sign in the field which was causing the $markup amount in uc_usps_markup() to be completely ignored.

I'm recommending we add a little better error checking for the markup value so that this doesn't fail silently for other UC users in the future.

Suggested Fix: Create a validation function for when uc_usps_admin_settings() is submitted. This will throw an error if NOT is_numeric() for the value of uc_usps_markup.

Comment	File	Size	Author
#2	uc_ups.admin_.inc_.patch	438 bytes	TR
#2
#2	uc_usps.admin_.inc_.patch	517 bytes	TR
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

TR CreditAttribution: TR commented 25 January 2010 at 01:40

Version:	5.x-1.7	» 6.x-2.x-dev
Assigned:	Unassigned	» TR

Comment #2

TR CreditAttribution: TR commented 4 February 2010 at 04:38

Status:

Active

» Needs review

File	Size
uc_usps.admin_.inc_.patch	517 bytes

uc_ups.admin_.inc_.patch	438 bytes

I rolled a patch for uc_usps and for uc_ups to fix this. The patch adds an is_numeric() check in the form validation function. I also committed a similar patch to my uc_fedex module, where I've had it in use for several weeks without a problem.