Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When an RTL language is enabled the new User menu is far off to the left. Attached patch adds one line to style-rtl.css in themes/garland.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | drupal-6.png | 78.3 KB | tstoeckler |
| rtl-usermenu.patch | 487 bytes | tstoeckler | |
| rtl-fix.png | 29.8 KB | tstoeckler | |
| rtl-error.png | 32.29 KB | tstoeckler | |
Comments
Comment #1
tixilite CreditAttribution: tixilite commentedLooks good to me.
Comment #2
cburschkaI was wondering about the hard-coded em margin, but looking at the screenshot it seems you're just aligning the menu with the left side bar so you don't need to worry about window resizing etc. Looks good, yes.
Comment #4
tstoecklerI don't believe that...
Comment #6
webchickComment #7
catchWell caught, the fix looks good.
Comment #8
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks. Changing the version number to Drupal 6?
Comment #9
tstoecklerDrupal 6 doesn't have the User menu so I guess that doesn't really make sense.
Comment #10
Gábor HojtsyWell, there is a secondary menu is Drupal 6 too, so it applies. I am not entirely sure however, that this is exactly how this is intended. Also, is the sidebar width specified in em?
Comment #11
tstoecklerWow, found this after a long time.
Patch still applies (with offset) and works. The sidebar is specified in em and the links stay at the right spot when zooming in the browser.
Screenshot attached. See the navigation menu to prove it's Drupal 6 :)
Comment #12
Gábor HojtsyOk, well, looking at the CSS, it looks like it is the same problem if you set Garland to have a right sidebar and keep an LTR language, right? It just does not have any indentation from right or left. So not sure this is actually a bug. If it is, why is it not mirrored in the LTR behavior when there is a right sidebar? Also, if there is no left sidebar, it will look pretty odd in RTL, right? I'm not convinced.
(Left and right sidebar referenced as displayed on the page, not necessarily the way it is named in Drupal).
Comment #13
tstoecklerI don't exactly get what you're saying, sorry.
I get
but I haven't verified that.
But from the rest I couldn't really see what the "needs work" part is, or if this is actually won't fix?!
Thanks in advance.
Comment #14
Gábor HojtsyOk, wording it maybe in a more actionable form:
Try: both sidebars (left, right) with LTR. Where is the user menu? Should it be there?
Try: no sidebars (or only right sidebar) with RTL. Where is the user menu? Should it be there?
Looks like these two will not be consistent with your proposed way of it working with the patch.
Comment #15
tstoecklerYou are correct. Both cases you mention align the user menu (secondary menu in D6) incorrectly. I checked D7 and it's a bug there too. So moving back there for now. I hope to roll a patch in the next days.