The items listed below affect both 5.x and 6.x of customer.itpl.php

--

I noticed when a customer invoice gets sent out, there are a couple of places that lines were wrapping that shouldn't be. The problem occurs from poorly formatted XHTML where the tag gets ignored by XHTML compliant mail programs (webmail in particular).

Line 23:
<span style="font-size: large;">[store-name]</span><br/>
should be:
<span style="font-size: large;">[store-name]</span><br />

Line 44:
<p><b><?php echo t('Username:'); ?></b> [new-username]<br/>
should be:
<p><b><?php echo t('Username:'); ?></b> [new-username]<br />

Basically, there needs to be a space before the slash in the <br /> (line-break) tag.

--

Additional thought ... there are two places where you have section headers with blue backgrounds and the text there is black. Black on blue is hard to read. I recommend a small edit in both of these places:

Line 55:
<td colspan="2" bgcolor="#006699">
change to:
<td colspan="2" bgcolor="#006699" style="color: white;">

Line 111:
<td colspan="2" bgcolor="#006699">
change to:
<td colspan="2" bgcolor="#006699" style="color: white;">

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rszrama’s picture

Version: 5.x-1.7 » 6.x-2.0-beta5
Status: Active » Patch (to be ported)

Made the changes in 2.x - will need to be backported.

cha0s’s picture

Assigned: Unassigned » cha0s
Status: Patch (to be ported) » Needs review
FileSize
21.71 KB
27.06 KB

Let's go the full 9...

rszrama’s picture

Version: 6.x-2.0-beta5 » 5.x-1.7
cha0s’s picture

Bump.

cha0s’s picture

Assigned: cha0s » Unassigned
TR’s picture

Status: Needs review » Needs work

+1 on fixing this issue. However, the patches in #2 are too old and need to be rerolled for the latest versions of Ubercart.

TR’s picture

Title: Invalid XHTML line break in customer.itpl.php » Invalid XHTML line breaks
TR’s picture

Version: 5.x-1.7 » 6.x-2.x-dev

Should be done in 6.x-2.x and backported to 5.x-1.x

TR’s picture

Title: Invalid XHTML line breaks » Invalid XHTML tags
Status: Needs work » Needs review
FileSize
34.21 KB
16.07 KB

OK, took care of all the <br>, <br/>, and <hr> tags in both Ubercart 6.x-2.x-dev and Ubercart 5.x-1.x-dev.

Looking for someone to apply these patches and see if they work...

TR’s picture

Committed D5 patch, still hope to hear from someone who's tested the D6 patch ...

TR’s picture

Status: Needs review » Fixed

Committed D6 patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kdebaas’s picture

Version: 6.x-2.x-dev » 5.x-1.10
Status: Closed (fixed) » Needs work

Crossreferencing from #880908: preg_replace() [<a href='function.preg-replace'>function.preg-replace</a>]: Unknown modifier '&gt;' . It looks like some forward slashes need to be escaped.

TR’s picture

Version: 5.x-1.10 » 6.x-2.x-dev
Status: Needs work » Closed (fixed)
Druid’s picture

Is the statement here that <br/> is somehow incorrect XHTML (it's not), or that certain buggy mail programs only recognize <br /> (with space)? Note that the same problem may occur with hr, img, and other self-closing tags. Before going too far, are email readers all XHTML-compatible now, or are many out there still only HTML?