The items listed below affect both 5.x and 6.x of customer.itpl.php
--
I noticed when a customer invoice gets sent out, there are a couple of places that lines were wrapping that shouldn't be. The problem occurs from poorly formatted XHTML where the tag gets ignored by XHTML compliant mail programs (webmail in particular).
Line 23:
<span style="font-size: large;">[store-name]</span><br/>
should be:
<span style="font-size: large;">[store-name]</span><br />
Line 44:
<p><b><?php echo t('Username:'); ?></b> [new-username]<br/>
should be:
<p><b><?php echo t('Username:'); ?></b> [new-username]<br />
Basically, there needs to be a space before the slash in the <br />
(line-break) tag.
--
Additional thought ... there are two places where you have section headers with blue backgrounds and the text there is black. Black on blue is hard to read. I recommend a small edit in both of these places:
Line 55:
<td colspan="2" bgcolor="#006699">
change to:
<td colspan="2" bgcolor="#006699" style="color: white;">
Line 111:
<td colspan="2" bgcolor="#006699">
change to:
<td colspan="2" bgcolor="#006699" style="color: white;">
Comment | File | Size | Author |
---|---|---|---|
#9 | 421366-D6.patch | 16.07 KB | TR |
#9 | 421366-D5.patch | 34.21 KB | TR |
#2 | 421366.br_fix.1.x.patch | 27.06 KB | cha0s |
#2 | 421366.br_fix.2.x.patch | 21.71 KB | cha0s |
Comments
Comment #1
rszrama CreditAttribution: rszrama commentedMade the changes in 2.x - will need to be backported.
Comment #2
cha0s CreditAttribution: cha0s commentedLet's go the full 9...
Comment #3
rszrama CreditAttribution: rszrama commentedComment #4
cha0s CreditAttribution: cha0s commentedBump.
Comment #5
cha0s CreditAttribution: cha0s commentedComment #6
TR CreditAttribution: TR commented+1 on fixing this issue. However, the patches in #2 are too old and need to be rerolled for the latest versions of Ubercart.
Comment #7
TR CreditAttribution: TR commentedComment #8
TR CreditAttribution: TR commentedShould be done in 6.x-2.x and backported to 5.x-1.x
Comment #9
TR CreditAttribution: TR commentedOK, took care of all the <br>, <br/>, and <hr> tags in both Ubercart 6.x-2.x-dev and Ubercart 5.x-1.x-dev.
Looking for someone to apply these patches and see if they work...
Comment #10
TR CreditAttribution: TR commentedCommitted D5 patch, still hope to hear from someone who's tested the D6 patch ...
Comment #11
TR CreditAttribution: TR commentedCommitted D6 patch.
Comment #13
kdebaas CreditAttribution: kdebaas commentedCrossreferencing from #880908: preg_replace() [<a href='function.preg-replace'>function.preg-replace</a>]: Unknown modifier '>' . It looks like some forward slashes need to be escaped.
Comment #14
TR CreditAttribution: TR commentedI'm going to leave this issue closed and address the problem over in #880908: preg_replace() [<a href='function.preg-replace'>function.preg-replace</a>]: Unknown modifier '>'
Comment #15
Druid CreditAttribution: Druid commentedIs the statement here that <br/> is somehow incorrect XHTML (it's not), or that certain buggy mail programs only recognize <br /> (with space)? Note that the same problem may occur with hr, img, and other self-closing tags. Before going too far, are email readers all XHTML-compatible now, or are many out there still only HTML?