Howdy...

Just a heads up that l() actually does a check_plain() on its own for link text. So when the title is encoded before sending it in you end up with some funky encoding for things like "Terms & Conditions" where the ampersand is double encoded.

Thanks!

CommentFileSizeAuthor
#2 421346.patch620 bytesroychri
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chill35’s picture

Chill35 CreditAttribution: Chill35 commented

Thanks Moonshine! I will fix this.

:)

roychri’s picture

roychri CreditAttribution: roychri commented
Status: Active » Needs review
FileSize
421346.patch620 bytes

Here's the patch for 1.10

DeFr’s picture

DeFr CreditAttribution: DeFr commented
Status: Needs review » Reviewed & tested by the community

Very simple patch, works as advertised and badly needed in case you have something that check_plain converts to an entity in the link label, otherwise the double escaping makes the entity visible (such as ' which is in the default fr.po) .

Thanks @roychri

Kars-T’s picture

Kars-T CreditAttribution: Kars-T commented
Status: Reviewed & tested by the community » Fixed

#421346 by roychri | Chill35: Fixed Double encoding on @link.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.