Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The polled column in the poll table was rather non-normalized. This patch adds a proper table.
Comment | File | Size | Author |
---|---|---|---|
#5 | drupal-head-poll-41755_1.diff | 4.39 KB | Cvbge |
#3 | poll.module.diff | 7.69 KB | drumm |
poll_4.patch | 7.63 KB | drumm | |
Comments
Comment #1
Dries CreditAttribution: Dries commentedIn other tables we use 'hostname' not 'host'. Maybe 'poll_votes' is better than 'poll_voted'? Looks like it would be more inline with the other naming conventions.
(Shouldn't we store the vote in the new table too? That would open up the possibility to change your vote or to see who voted what. Looks like the next logical step. Maybe in another patch.)
Comment #2
drummColumn changes are done.
Which vote someone did is more of a feature. I'm happy with waiting until after HEAD is reopened for that if there is demand.
Comment #3
drummComment #4
Dries CreditAttribution: Dries commentedTested and committed to HEAD. Thanks.
Comment #5
Cvbge CreditAttribution: Cvbge commentedSome fixes:
1. "int(10)" -> "int", fixed typo in index name [pgsql change only]
2. added defaults for uid and hostname (needed for both)
3. postgres supports "DROP column" syntax
4. added missing DELETEs for new table in poll_delete() and poll_update()
Comment #6
drummLooks good to me.
+1
Comment #7
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks.
Comment #8
(not verified) CreditAttribution: commented