Input format selection not in fieldset [#40628]

For some reason, the nodeapi 'op form' change (http://drupal.org/node/39778) removed the fieldset surrounding the 'input format' selection on node add/edit forms. See the CVS diff: http://cvs.drupal.org/viewcvs/drupal/drupal/modules/filter.module?r1=1.9...

This patch restores the fieldset, by once again nesting all elements within an array element called 'filter'. The 'op form' patch kept (and even slightly improved) the fieldset properties, and these are unchanged here.

Comment	File	Size	Author
	filter_fieldset.patch	1.62 KB	Jaza

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

drewish CreditAttribution: drewish commented 10 December 2005 at 02:48

I'd been wondering if this was an intentional change or not. The patch looks good though.

Comment #2

chx CreditAttribution: chx commented 10 December 2005 at 07:25

Please test this patch throughly. Say, PHP filter works for nodes, comments, custom blocks?

Comment #3

Jaza CreditAttribution: Jaza commented 10 December 2005 at 10:57

Status:

Needs review

» Reviewed & tested by the community

Just tested this patch by applying the PHP filter on a node, a comment, and a custom block. All works fine.

chx: I don't really see what problems this patch could cause. It's making a very small and basic change, and all it's doing is bringing back the old fieldset that was already there before. Am I missing something?

As far as I can see, the patch is ready to go in.