this precludes the use of (say) an animated gif for "hot" forum topics.

if it makes sense to people as a fix, I'll create a patch that takes the extention from a admin settings variable.

CommentFileSizeAuthor
#6 40534_1.patch2.54 KBWesley Tanaka
#5 40534_0.patch3.29 KBWesley Tanaka
#2 40534.patch1.57 KBWesley Tanaka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Morbus Iff’s picture

Morbus Iff
they/them
CreditAttribution: Morbus Iff commented
Status: Active » Closed (won't fix)

This is a user-defined setting, see admin/forum/configure and "forum icon path".

Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented
Status: Closed (won't fix) » Needs review
FileSize
40534.patch1.57 KB

Sorry, clearly I wasn't clear enough.

    // default
    $file = variable_get('forum_icon_path', 'misc') ."/forum-$icon.png";

I'm talking about the "png" part of that code.

The current CVS looks like it might limp along well enough to get it working on my site, so I took the plunge and committed it. Since it's easier for me to create patches now, I'm attaching one which explains what I mean (and incidentally would also fix the problem)

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Needs work

I vote against more settings. Let's just make sure this is 100% themable using the theme system.

Dries’s picture

Dries CreditAttribution: Dries commented

If it is fully themeable, we can probably remove the "Forum icon path" setting too.

Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented
Status: Needs work » Needs review
FileSize
40534_0.patch3.29 KB

reasonable idea

Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented
FileSize
40534_1.patch2.54 KB

a different approach which reduces the burden on the person overriding the theme function.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Committed a modified version of your patch to HEAD. Don't worry about backward compatibility.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Version: » 4.6.5
Status: Closed (fixed) » Active

This needs documentation at http://drupal.org/node/25297

Robert Castelo’s picture

Robert Castelo CreditAttribution: Robert Castelo commented

Added documentation telling themers that theme_forum_icon() is now available.

Robert Castelo’s picture

Robert Castelo CreditAttribution: Robert Castelo commented
Status: Active » Closed (fixed)