Any chance this might be worked on? There are lots of sites still on D5 and this is a critical module.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dragonwize’s picture

Title: drupal 5 backport » Developer wanted for D5 backport
Status: Active » Postponed

I am focusing my attention on the D6 & D7. Also since all my sites have been upgraded to D6 for quite some time now, I am afraid I would not put much effort in working on a D5 version to keep it maintained properly.

Other developers are welcome to backport the module though. Be mindful though that the module will be going through major revisions in the next versions.

Marking this as postponed so it will stay shown in the default issue queue list for others to see.

sun’s picture

I considered to do this a few times already, but I'm not sure whether you want me. ;)

tannerjfco’s picture

I second the need for this to be backported to D5. Unfortunately it's just not an option at this time for me to upgrade my site to D6, and I desperately need the functionality this module provides. I know there is the Filter by Content Type module, but it doesn't work with the WYSIWYG API module, and I've read that this module does the job in this situation.

freddyseubert’s picture

subscribing

sun’s picture

Status: Postponed » Needs review
FileSize
18.24 KB

No response means most likely 'no'.

Anyway.

Not included: CCK support. Implementing that requires a fairly complex helper function to recursively step through node forms, identifying CCK textarea fields (while taking fieldgroups into account), jumping to the next sibling (which should be the filter format widget), and applying better format's override function there. I have no interest (and no time) to work on that currently. If you don't need CCK support, this backport works flawlessly.

freddyseubert’s picture

Thank you very much for your work. But I think this patch does not apply cleanly to the 6.x-1.0 version of the module.. I'll post you the output in terminal:

>>> patch < better_formats-DRUPAL-5.patch.txt
patching file README.txt
Hunk #1 FAILED at 10.
1 out of 1 hunk FAILED -- saving rejects to file README.txt.rej
patching file better-formats-defaults-admin-form.tpl.php
Hunk #1 FAILED at 18.
1 out of 1 hunk FAILED -- saving rejects to file better-formats-defaults-admin-form.tpl.php.rej
patching file better_formats.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file better_formats.info.rej
patching file better_formats.install
Hunk #2 FAILED at 65.
Hunk #3 succeeded at 74 (offset -4 lines).
1 out of 3 hunks FAILED -- saving rejects to file better_formats.install.rej
patching file better_formats.module
Hunk #3 succeeded at 103 (offset -5 lines).
Hunk #4 succeeded at 127 (offset -5 lines).
Hunk #5 succeeded at 165 (offset -5 lines).
Hunk #6 succeeded at 182 (offset -5 lines).
Hunk #7 succeeded at 193 (offset -5 lines).
Hunk #8 succeeded at 204 (offset -5 lines).
Hunk #9 succeeded at 221 (offset -5 lines).
Hunk #10 succeeded at 241 (offset -6 lines).
Hunk #11 FAILED at 270.
Hunk #12 FAILED at 285.
Hunk #13 succeeded at 295 (offset -10 lines).
Hunk #14 succeeded at 315 (offset -10 lines).
Hunk #15 succeeded at 325 (offset -10 lines).
2 out of 15 hunks FAILED -- saving rejects to file better_formats.module.rej
patching file better_formats_defaults.admin.inc
Hunk #1 succeeded at 39 (offset -1 lines).
Hunk #2 FAILED at 47.
Hunk #3 FAILED at 68.
Hunk #4 succeeded at 201 (offset -2 lines).
2 out of 4 hunks FAILED -- saving rejects to file better_formats_defaults.admin.inc.rej

Am I missing something?

Thanks in advance, Freddy

sun’s picture

Of course it does not. It applies against CVS.

wwwoliondorcom’s picture

Also waiting for a D5 version...

Thanks !

ScoutBaker’s picture

@wwwoliondorcom: The maintainer of the module stated they aren't going to do it. Sun provided a patch in #5 above. You'll need to take it from there.

drupalninja99’s picture

can someone upload the whole module for those of us not real savvy with cvs patching?

FatPitchFinancials’s picture

FileSize
18.85 KB

Here is the whole module.

I'm having some problems getting it to work just right. It seems to cause the "Input format" control widget on node submissions to show up twice on blog and storylink submission forms, but it works normally on the story, page and forum submission forms. Any ideas on how to fix the problem of two Input format drop downs?

mcurry’s picture

subscribe

wwwoliondorcom’s picture

Hi,

Any update ? Does it work now ?

Thanks.

dragonwize’s picture

Issue summary: View changes
Status: Needs review » Closed (won't fix)

6.x is now unsupported.