..../sites/all/modules/backup_migrate/backup_migrate.module on line 918

backups are incomplete and not following the schedule
drupal 6.10
poormanscron 6.x 1.0

Comments

ronan’s picture

This should have been fixed by #367897: PHP Fatal error: Call to undefined function file_scan_directory() in modules/backup_migrate/backup_migrate.module on line 122. Please download the latest 6.x-1.x-dev and confirm that it is fixed. If it works for you I'll roll a new stable release with this fix.

Thanks
Ronan

ronan’s picture

Status: Active » Fixed

forgot to change status. reopen if that fix did not work.

R

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kenorb’s picture

kenorb’s picture

I've got the latest and I've got:
Fatal error: Call to undefined function file_directory_temp() in backup_migrate/includes/files.inc on line 35
URL: node/%0

ronan’s picture

I can't reproduce this with any of the configurations I can think of. Can you give me any more clues as to what might be going on in your setup?

Thanks
R

kenorb’s picture

Status: Closed (fixed) » Active

It happen for anonymous on pages which has been cached.
Drupal executing: DRUPAL_BOOTSTRAP_LATE_PAGE_CACHE case,
after that getting cache page drupal_page_cache_header($cache);
and then do: bootstrap_invoke_all('exit');
In this case, file.inc is not included, so that function is not defined when Drupal is not fully executed.

Backtrace:
_drupal_bootstrap -> bootstrap_invoke_all('exit') -> backup_migrate_exit -> backup_migrate_cleanup -> _backup_migrate_temp_files_delete -> file_directory_temp!

It happen on each cached page.

ronan’s picture

That's really helpful debugging info, I'll try and reproduce it now and let you know what I find.

ronan’s picture

Version: 6.x-1.2 » 6.x-1.x-dev
Status: Active » Fixed

Ok, I just pulled the hook_exit implementation altogether. I don't think it's needed since the file cleanup happens, on cron, on failure, on success, on system_shutdown, etc, etc etc. Removing that function makes the module compatible with aggressive caching too, so extra bonus there.

If you're still having trouble, try the latest 2.x dev. It's a near-complete rewrite and does not suffer from the same issues as the 1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.